Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update decoder pretrained lm docs #2291

Closed
wants to merge 2 commits into from
Closed

Update decoder pretrained lm docs #2291

wants to merge 2 commits into from

Conversation

carolineechen
Copy link
Contributor

@carolineechen carolineechen commented Mar 25, 2022 •
edited
Loading

build_docs test is failing on CI with ImportError: cannot import name 'environmentfilter' from 'jinja2', but with local build:

Screen Shot 2022-03-25 at 4 02 53 PM

@carolineechen carolineechen requested review from mthrok, hwangjeff and nateanl and removed request for mthrok, hwangjeff and nateanl March 25, 2022 16:41
mthrok
mthrok approved these changes Mar 25, 2022
View reviewed changes
Copy link
Collaborator

@mthrok mthrok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good the build error seems to be related to Jinja version. Let's fix it in a separate PR.

sphinx-doc/sphinx#10291 (comment)

docs/source/prototype.ctc_decoder.rst Outdated Show resolved Hide resolved
@mthrok
Update docs/source/prototype.ctc_decoder.rst
559811c 
Co-authored-by: moto <855818+mthrok@users.noreply.github.com>
@facebook-github-bot
Copy link
Contributor

@carolineechen has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

xiaohui-zhang pushed a commit to xiaohui-zhang/audio that referenced this pull request May 4, 2022
@xiaohui-zhang
Update decoder pretrained lm docs (pytorch#2291)
f0bad77 
Summary:
`build_docs` test is failing on CI with `ImportError: cannot import name 'environmentfilter' from 'jinja2'`, but with local build:

<img width="902" alt="Screen Shot 2022-03-25 at 4 02 53 PM" src="https://user-images.githubusercontent.com/16568633/160157472-c91ff9b2-a2be-4c5d-959e-53b9f45425c6.png">

Pull Request resolved: pytorch#2291

Reviewed By: mthrok

Differential Revision: D35147098

Pulled By: carolineechen

fbshipit-source-id: 682b3800d0ed5c56b402d83f221136725051ba7e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mthrok mthrok mthrok approved these changes

@nateanl nateanl Awaiting requested review from nateanl

@hwangjeff hwangjeff Awaiting requested review from hwangjeff

Assignees
No one assigned
Labels
CLA Signed improvement module: docs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@carolineechen @facebook-github-bot @mthrok