[Cherry-picked 0.11.1] Use sourceforge url to fetch zlib #2297
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mthrok
reviewed
Mar 29, 2022
third_party/zlib/CMakeLists.txt
Outdated
| URL https://zlib.net/zlib-1.2.11.tar.gz | ||
| URL_HASH SHA256=c3e5e9fdd5004dcb542feda5ee4f0ff0744628baf8ed2dd5d66f8ca1197cb1a1 | ||
| URL https://zlib.net/zlib-1.2.12.tar.gz | ||
| URL_HASH SHA256=91844808532e5ce316b3c010929493c0244f3d37593afd6de04f71821d5136d9 |
There was a problem hiding this comment.
Although this is correct. Can we actually keep 1.2.11 and instead update the URL to one on sourceforge? i.e. URL https://sourceforge.net/projects/libpng/files/zlib/1.2.11/zlib-1.2.11.tar.gz
Here are the reasons.
- We learned that zlib.net would delete previous releases when there is a new release. This gives concerns because when there is a new release of zlib, then the source build would break again. Due to this, the latest versioned release (0.11) cannot be built from source. If we rely on sourceforge.net, then we can expect that old releases are preserved.
- Currently there is no 1.2.12 on sourceforge. https://sourceforge.net/projects/libpng/files/zlib/ We need to wait for them to upload 1.2.12 to source forge.
mthrok
approved these changes
Mar 30, 2022
|
@nateanl has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
nateanl
added a commit
that referenced
this pull request
Mar 30, 2022
Summary: This PR addresses #2295 by updating `zlib`'s url to the one on sourceforge.net. `zlib` 1.2.11 source code is removed from the official site. According to https://zlib.net, ```Due to the bug fixes, any installations of 1.2.11 should be replaced with 1.2.12.``` sourceforge preserves the older versions thus is more stable. The PR keep 1.2.11 as currently there is no 1.2.12 on sourceforge. Pull Request resolved: #2297 Reviewed By: mthrok Differential Revision: D35251361 Pulled By: nateanl fbshipit-source-id: 174c2c2e1c34bef9799bbacfd1e12c8ff13ff15d
mthrok
changed the title
xiaohui-zhang
pushed a commit
to xiaohui-zhang/audio
that referenced
this pull request
May 4, 2022
Summary: This PR addresses pytorch#2295 by updating `zlib`'s url to the one on sourceforge.net. `zlib` 1.2.11 source code is removed from the official site. According to https://zlib.net, ```Due to the bug fixes, any installations of 1.2.11 should be replaced with 1.2.12.``` sourceforge preserves the older versions thus is more stable. The PR keep 1.2.11 as currently there is no 1.2.12 on sourceforge. Pull Request resolved: pytorch#2297 Reviewed By: mthrok Differential Revision: D35251361 Pulled By: nateanl fbshipit-source-id: 174c2c2e1c34bef9799bbacfd1e12c8ff13ff15d
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses #2295 by updating
zlib's url to the one on sourceforge.net.zlib1.2.11 source code is removed from the official site. According to https://zlib.net,Due to the bug fixes, any installations of 1.2.11 should be replaced with 1.2.12.sourceforge preserves the older versions thus is more stable. The PR keep 1.2.11 as currently there is no 1.2.12 on sourceforge.