Add devices/properties badges #2321
Conversation
mthrok
force-pushed
the
badges-2
branch
2 times, most recently
from
fb5a293 to
55d2c61
Compare
| @@ -0,0 +1,97 @@ | |||
| Supported Features | |||
There was a problem hiding this comment.
thoughts on renaming this "Supported Properties" or something of that nature? could be slightly confusing to use feature as both the overall feature set and as a subset (autograd/torchscript)
There was a problem hiding this comment.
Yes! I was also feeling that "feature" is overloaded here. Thanks for the suggestion. Will do.
There was a problem hiding this comment.
Updated. It still uses the ambiguous feature term. Let me know what you think.
There was a problem hiding this comment.
maybe "Supported PyTorch Features" to reflect that they're native to pytorch?
There was a problem hiding this comment.
I am thinking to mention numerical compatibility with other libraries such as librosa and Kaldi, so let me follow-up on this one.
Co-authored-by: Caroline Chen <carolinechen@fb.com>
| @@ -0,0 +1,97 @@ | |||
| Supported Features | |||
There was a problem hiding this comment.
maybe "Supported PyTorch Features" to reflect that they're native to pytorch?
Co-authored-by: hwangjeff <hwangjeff@users.noreply.github.com>
|
@mthrok has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
Hey @mthrok. |
Summary: Add badges of supported properties and devices to functionals and transforms. This commit adds `.. devices::` and `.. properties::` directives to sphinx. APIs with these directives will have badges (based off of shields.io) which link to the page with description of these features. Continuation of pytorch#2316 Excluded dtypes for further improvement, and actually added badges to most of functional/transforms. Pull Request resolved: pytorch#2321 Reviewed By: hwangjeff Differential Revision: D35489063 Pulled By: mthrok fbshipit-source-id: f68a70ebb22df29d5e9bd171273bd19007a81762
Add badges of supported properties and devices to functionals and transforms.
This commit adds
.. devices::and.. properties::directives to sphinx.APIs with these directives will have badges (based off of shields.io) which link to the
page with description of these features.
Continuation of #2316
Excluded dtypes for further improvement, and actually added badges to most of functional/transforms.