Support specifying decoder and its options #2327
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mthrok
force-pushed
the
ffmpeg-decoder-option
branch
from
becb516 to
7365ce2
Compare
carolineechen
approved these changes
Apr 13, 2022
|
@mthrok has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
mthrok
added a commit
to mthrok/audio
that referenced
this pull request
Apr 13, 2022
Summary: This commit adds support to specify decoder to Streamer's add stream method. This is roughly equivalent to `ffmpeg`'s `-c:v foo` and `-c:a foo` options. This allows to override the decoder codec and/or specify the option of the decoder. This change allows to specify Nvidia NVDEC codec for supported formats, which uses dedicated hardware for decoding the video. --- Note: The CL might look overwhelming, but it's essentially, add new parameters in Python, and pass them down all the way to `AVCodecContextPtr`, which initializes the actual decoder implementation (`AVCodecContext`.) Pull Request resolved: pytorch#2327 Differential Revision: D35626904 Pulled By: mthrok fbshipit-source-id: 6d23477f0a459b139c15d62a4ed4e4fad5ed9c99
|
This pull request was exported from Phabricator. Differential Revision: D35626904 |
mthrok
force-pushed
the
ffmpeg-decoder-option
branch
from
7365ce2 to
cfca44b
Compare
mthrok
added a commit
to mthrok/audio
that referenced
this pull request
Apr 14, 2022
Summary: This commit adds support to specify decoder to Streamer's add stream method. This is roughly equivalent to `ffmpeg`'s `-c:v foo` and `-c:a foo` options. This allows to override the decoder codec and/or specify the option of the decoder. This change allows to specify Nvidia NVDEC codec for supported formats, which uses dedicated hardware for decoding the video. --- Note: The CL might look overwhelming, but it's essentially, add new parameters in Python, and pass them down all the way to `AVCodecContextPtr`, which initializes the actual decoder implementation (`AVCodecContext`.) Pull Request resolved: pytorch#2327 Differential Revision: D35626904 Pulled By: mthrok fbshipit-source-id: 94ddbf5f1c3beb01194675d2792900cf873922f5
mthrok
force-pushed
the
ffmpeg-decoder-option
branch
from
cfca44b to
39c9213
Compare
|
This pull request was exported from Phabricator. Differential Revision: D35626904 |
mthrok
added a commit
to mthrok/audio
that referenced
this pull request
Apr 14, 2022
Summary: This commit adds support to specify decoder to Streamer's add stream method. This is roughly equivalent to `ffmpeg`'s `-c:v foo` and `-c:a foo` options. This allows to override the decoder codec and/or specify the option of the decoder. This change allows to specify Nvidia NVDEC codec for supported formats, which uses dedicated hardware for decoding the video. --- Note: The CL might look overwhelming, but it's essentially, add new parameters in Python, and pass them down all the way to `AVCodecContextPtr`, which initializes the actual decoder implementation (`AVCodecContext`.) Pull Request resolved: pytorch#2327 Differential Revision: D35626904 Pulled By: mthrok fbshipit-source-id: dec2b67fdac390297fb7449d05ca35c219234370
mthrok
force-pushed
the
ffmpeg-decoder-option
branch
from
39c9213 to
488af4c
Compare
|
This pull request was exported from Phabricator. Differential Revision: D35626904 |
1 similar comment
|
This pull request was exported from Phabricator. Differential Revision: D35626904 |
mthrok
added a commit
to mthrok/audio
that referenced
this pull request
Apr 14, 2022
Summary: This commit adds support to specify decoder to Streamer's add stream method. This is roughly equivalent to `ffmpeg`'s `-c:v foo` and `-c:a foo` options. This allows to override the decoder codec and/or specify the option of the decoder. This change allows to specify Nvidia NVDEC codec for supported formats, which uses dedicated hardware for decoding the video. --- Note: The CL might look overwhelming, but it's essentially, add new parameters in Python, and pass them down all the way to `AVCodecContextPtr`, which initializes the actual decoder implementation (`AVCodecContext`.) Pull Request resolved: pytorch#2327 Differential Revision: D35626904 Pulled By: mthrok fbshipit-source-id: f1301dd09e3259a928fd82cbc0431739f8a16c89
mthrok
force-pushed
the
ffmpeg-decoder-option
branch
2 times, most recently
from
7de1988 to
3409a41
Compare
|
@mthrok has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
mthrok
force-pushed
the
ffmpeg-decoder-option
branch
from
3409a41 to
63275e5
Compare
mthrok
added a commit
to mthrok/audio
that referenced
this pull request
Apr 14, 2022
Summary: This commit adds support to specify decoder to Streamer's add stream method. This is roughly equivalent to `ffmpeg`'s `-c:v foo` and `-c:a foo` options. This allows to override the decoder codec and/or specify the option of the decoder. This change allows to specify Nvidia NVDEC codec for supported formats, which uses dedicated hardware for decoding the video. --- Note: The CL might look overwhelming, but it's essentially, add new parameters in Python, and pass them down all the way to `AVCodecContextPtr`, which initializes the actual decoder implementation (`AVCodecContext`.) Pull Request resolved: pytorch#2327 Differential Revision: D35626904 Pulled By: mthrok fbshipit-source-id: b411862049affae1e798a639747080bc1c64dd01
mthrok
force-pushed
the
ffmpeg-decoder-option
branch
from
63275e5 to
36e9100
Compare
|
This pull request was exported from Phabricator. Differential Revision: D35626904 |
Summary: This commit adds support to specify decoder to Streamer's add stream method. This is roughly equivalent to `ffmpeg`'s `-c:v foo` and `-c:a foo` options. This allows to override the decoder codec and/or specify the option of the decoder. This change allows to specify Nvidia NVDEC codec for supported formats, which uses dedicated hardware for decoding the video. --- Note: The CL might look overwhelming, but it's essentially, add new parameters in Python, and pass them down all the way to `AVCodecContextPtr`, which initializes the actual decoder implementation (`AVCodecContext`.) Pull Request resolved: pytorch#2327 Differential Revision: D35626904 Pulled By: mthrok fbshipit-source-id: 1840dd8932b4c2d62b3e3eaa0de4c50af371547b
mthrok
force-pushed
the
ffmpeg-decoder-option
branch
from
36e9100 to
121a611
Compare
|
This pull request was exported from Phabricator. Differential Revision: D35626904 |
|
Hey @mthrok. |
xiaohui-zhang
pushed a commit
to xiaohui-zhang/audio
that referenced
this pull request
May 4, 2022
Summary: This commit adds support to specify decoder to Streamer's add stream method. This is roughly equivalent to `ffmpeg`'s `-c:v foo` and `-c:a foo` options. This allows to override the decoder codec and/or specify the option of the decoder. This change allows to specify Nvidia NVDEC codec for supported formats, which uses dedicated hardware for decoding the video. --- Note: The CL might look overwhelming, but it's essentially, add new parameters in Python, and pass them down all the way to `AVCodecContextPtr`, which initializes the actual decoder implementation (`AVCodecContext`.) Pull Request resolved: pytorch#2327 Reviewed By: carolineechen Differential Revision: D35626904 Pulled By: mthrok fbshipit-source-id: a115ed548624e53c16bacfecff5aa6c9d4e8bede
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds support to specify decoder to Streamer's add stream method.
This is roughly equivalent to
ffmpeg's-c:v fooand-c:a foooptions.This allows to override the decoder codec and/or specify the option of
the decoder.
This change allows to specify Nvidia NVDEC codec for supported formats,
which uses dedicated hardware for decoding the video.
Note: The CL might look overwhelming, but it's essentially, add new parameters in Python, and pass them down all the way to
AVCodecContextPtr, which initializes the actual decoder implementation (AVCodecContext.)