-
Notifications
You must be signed in to change notification settings - Fork 662
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Conformer RNN-T LibriSpeech training recipe #2329
Conversation
745e36d
to
dda2ce3
Compare
@hwangjeff has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
@hwangjeff has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
): | ||
super().__init__() | ||
|
||
self.model = conformer_rnnt_base() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just realized num_symbols is hardcoded as 1024 inside conformer_rnnt_base. IMO conformer_rnnt_base should only be used in test cases. Here we should initiate the model explicitly via conformer_rnnt_model, and pass self.sp_model.get_piece_size() to "num_symbols", and consider exposing more inputs to the input of LightningModule later on.
6fd974d
to
854ece9
Compare
@hwangjeff has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
1 similar comment
@hwangjeff has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
da751eb
to
3437eef
Compare
@hwangjeff has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Stamp.
Hey @hwangjeff. |
Summary: Adds Conformer RNN-T LibriSpeech training recipe to examples directory. Produces 30M-parameter model that achieves the following WER: | | WER | |:-------------------:|-------------:| | test-clean | 0.0310 | | test-other | 0.0805 | | dev-clean | 0.0314 | | dev-other | 0.0827 | Pull Request resolved: pytorch#2329 Reviewed By: xiaohui-zhang Differential Revision: D35578727 Pulled By: hwangjeff fbshipit-source-id: afa9146c5b647727b8605d104d928110a1d3976d
Adds Conformer RNN-T LibriSpeech training recipe to examples directory.
Produces 30M-parameter model that achieves the following WER: