Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move multi-channel modules to a separate file #2382

Closed
wants to merge 2 commits into from
Closed

Move multi-channel modules to a separate file #2382

wants to merge 2 commits into from

Conversation

nateanl
Copy link
Member

@nateanl nateanl commented May 11, 2022

The modules include:

  • PSD
  • MVDR
  • RTFMVDR
  • SoudenMVDR

@facebook-github-bot
Copy link
Contributor

@nateanl has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

mthrok
mthrok approved these changes May 11, 2022
View reviewed changes
Copy link
Collaborator

@mthrok mthrok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The following method does not use self, so putting them outside of MVDR class would make the MVDR implementation lean and easier to follow.

  • MVDR._get_steering_vector_evd
  • MVDR._get_steering_vector_power
  • MVDR._apply_beamforming_vector
  • MVDR._tik_reg

@nateanl
Copy link
Member Author

nateanl commented May 11, 2022

The following method does not use self, so putting them outside of MVDR class would make the MVDR implementation lean and easier to follow.
MVDR._get_steering_vector_evd
MVDR._get_steering_vector_power
MVDR._apply_beamforming_vector
MVDR._tik_reg

Yes, after this PR is merged, I will replace those methods with the ones in functional.

@nateanl nateanl mentioned this pull request May 12, 2022
Closed
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mthrok mthrok mthrok approved these changes

@carolineechen carolineechen carolineechen approved these changes

@hwangjeff hwangjeff Awaiting requested review from hwangjeff

@xiaohui-zhang xiaohui-zhang Awaiting requested review from xiaohui-zhang

Assignees
No one assigned
Labels
CLA Signed improvement module: ops
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@nateanl @facebook-github-bot @mthrok @carolineechen