Update audio feature extraction tutorial #2391
Conversation
mthrok
force-pushed
the
update-feature-extraction-tutorial
branch
from
ca76d1c to
7c35c28
Compare
|
The image in Section 2 seems not rendered correctly. |
@nateanl Fixed the asset link. thanks! |
| # The following diagram shows the relashipship between common audio features | ||
| # and torchaudio APIs to generate them. | ||
| # | ||
| # .. image:: https://download.pytorch.org/torchaudio/tutorial-assets/torchaudio_feature_extractions.png |
There was a problem hiding this comment.
Do you plan to add ComputeDelta to this diagram? It can be above the MFCC feature IMO. Delta feature is often used along with MFCC by kaldi users for ASR.
There was a problem hiding this comment.
Not this time. let's followup later.
|
|
||
| ###################################################################### | ||
| # | ||
|
|
||
| plot_spectrogram(melspec[0], title="MelSpectrogram - torchaudio", ylabel="mel freq") | ||
|
|
||
| ###################################################################### | ||
| # Comparison against librosa |
There was a problem hiding this comment.
This section doesn't have section index, is it intended?
- Adopt torchaudio.utils.download_asset to simplify asset management. - Break down the first section about helper functions. - Reduce the number of helper functions - Add section number
mthrok
force-pushed
the
update-feature-extraction-tutorial
branch
from
7c35c28 to
894e7b3
Compare
| pitch = F.detect_pitch_frequency(waveform, sample_rate) | ||
| plot_pitch(waveform, sample_rate, pitch) | ||
| play_audio(waveform, sample_rate) | ||
| plot_pitch(SPEECH_WAVEFORM, SAMPLE_RATE, pitch) | ||
|
|
||
| ###################################################################### | ||
| # Kaldi Pitch (beta) |
There was a problem hiding this comment.
ooc is this still in beta phase?
Co-authored-by: nateanl <zni@fb.com> Co-authored-by: Caroline Chen <carolinechen@fb.com>
|
@mthrok has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
Hey @mthrok. |
https://app.circleci.com/pipelines/github/pytorch/audio/11065/workflows/8fd5da50-71af-46f3-8c95-cadbc7be3a1a/jobs/704592