Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add assertion checks to multi-channel functions #2401

Closed
wants to merge 4 commits into from

Conversation

nateanl
Copy link
Member

@nateanl nateanl commented May 18, 2022

  • The multi-channel functions only support complex-valued tensors for spectrogram and PSD matrices.
  • The mask can be real-valued or complex-valued, hence there is no explicit assertion for mask.
  • The shape of input Tensors need to be verified before the computation. For example, the shape of PSD matrix must be (..., freq, channel, channel), the shape of the mask must be (..., freq, time), etc.
  • The autograd unittest of apply_beamforming has wrong dimensions for beamform_weights detected by the assertion check. FIx it in this PR.

@facebook-github-bot
Copy link
Contributor

@nateanl has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants