Refactor StreamReader C++ codebase #2403
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mthrok
force-pushed
the
ffmpeg-refactor-cpp2
branch
4 times, most recently
from
d83caec to
db61e62
Compare
|
@mthrok has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
carolineechen
approved these changes
May 27, 2022
Summary: `Streamer` has been renamed to `StreamReader` when it was moved from prototype to beta. This commit applies the same name change to the C++ source code. Pull Request resolved: pytorch#2403 Reviewed By: carolineechen Differential Revision: D36613053 Pulled By: mthrok fbshipit-source-id: 589b84330aa08efb3305b05fab8dc5cfc26a270d
|
This pull request was exported from Phabricator. Differential Revision: D36613053 |
mthrok
force-pushed
the
ffmpeg-refactor-cpp2
branch
from
db61e62 to
34ba275
Compare
mthrok
changed the title
|
Hey @mthrok. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Streamerhas been renamed toStreamReaderwhen it was moved from prototype to beta.This commit applies the same name change to the C++ source code.
Fix miscellaneous lint issues
Make the code compilable on FFmpeg 5