Raising RuntimeErrors when datasets missing #2430
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skim0514
changed the title
nateanl
reviewed
Jun 1, 2022
torchaudio/datasets/cmuarctic.py
Outdated
| @@ -120,7 +120,12 @@ def __init__( | |||
| checksum = _CHECKSUMS.get(url, None) | |||
| download_url_to_file(url, archive, hash_prefix=checksum) | |||
| extract_archive(archive) | |||
|
|
|||
| else: | |||
| if not os.path.exists(archive): | |||
There was a problem hiding this comment.
Here it assumes download is False, and archive is not found. If users extracted the files to self._path and deleted the archive, it should not throw a runtime error.
We can change the archive to self._path as a workaround.
torchaudio/datasets/cmuarctic.py
Outdated
Comment on lines
126
to
127
| "The file is not found in the following location. " | ||
| f"Set `download=True` to download it. {archive}" |
There was a problem hiding this comment.
It can be rephrased like this:
Suggested change
| "The file is not found in the following location. " | |
| f"Set `download=True` to download it. {archive}" | |
| f"The path {self._path} doesn't exist." | |
| "Please check the ``root`` path or set `download=True` to download it" |
|
@skim0514 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
carolineechen
approved these changes
Jun 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checks download flag and raises error when dataset is missing given download flag exists. Unit tested manually.
edit: Changed path to check as well as comment that is returned.