Remove possible manual seeds from test files. #2436
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mthrok
reviewed
Jun 2, 2022
| items_input = [[ele[i].clone() for ele in inputs] for i in range(n)] | ||
| items_result = torch.stack([functional(*items_input[i]) for i in range(n)]) | ||
|
|
||
| # Batch the input and run | ||
| torch.random.manual_seed(seed) |
There was a problem hiding this comment.
These two seeds cannot be removed. This helper function is supposed to run functions on the same seed twice and compare the results.
mthrok
reviewed
Jun 2, 2022
| @@ -16,12 +16,10 @@ def assert_batch_consistency(self, transform, batch, *args, atol=1e-8, rtol=1e-5 | |||
| n = batch.size(0) | |||
|
|
|||
| # Compute items separately, then batch the result | |||
| torch.random.manual_seed(seed) | |||
There was a problem hiding this comment.
Same here, the helper method must run the given function twice with the same seed. So these two seedings in this method have to stay.
added 3 commits
June 2, 2022 13:49
|
@skim0514 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
carolineechen
approved these changes
Jun 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For test files where applicable, removed manual seeds where applicable. Refactoring #2267