Refactor M1 logic and fix version #2438
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
atalman
changed the title
mthrok
approved these changes
Jun 2, 2022
| WHL_NAME=torchaudio-${BUILD_VERSION}-cp${PY_VERS/.}-cp${PY_VERS/.}-macosx_11_0_arm64.whl | ||
| conda create -yp ${ENV_NAME} python=${PY_VERS} numpy cmake ninja libpng openjpeg wheel pkg-config | ||
| conda run -p ${ENV_NAME} python3 -mpip install torch --extra-index-url=https://download.pytorch.org/whl/nightly | ||
| conda create -yp ${ENV_NAME} python=${PY_VERS} numpy cmake pytest ninja libpng openjpeg wheel pkg-config |
There was a problem hiding this comment.
nit: seems like the unit test step was removed in the end. pytest is not necessary in that case.
(also libpng and openjpeg have nothing to do in audio repo)
malfet
approved these changes
Jun 3, 2022
|
@atalman has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
nateanl
approved these changes
Jun 3, 2022
|
Hey @atalman. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor M1 logic
These improvement introduced in following PR: pytorch/vision#6117