Use dlopen for sox #3082
Closed
Use dlopen for sox #3082
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mthrok
force-pushed
the
dynamic-link-sox
branch
4 times, most recently
from
f68dd6b to
2e330b5
Compare
|
@mthrok has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/audio/3082
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 New Failure, 3 Unrelated FailuresAs of commit 88c3f02: BROKEN TRUNK - The following jobs failed but were present on the merge base da21202:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
mthrok
force-pushed
the
dynamic-link-sox
branch
2 times, most recently
from
ba9a8ef to
df19aa6
Compare
mthrok
force-pushed
the
dynamic-link-sox
branch
3 times, most recently
from
1954488 to
87b376e
Compare
mthrok
force-pushed
the
dynamic-link-sox
branch
5 times, most recently
from
077fd6f to
f46b7c5
Compare
|
@mthrok has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
mthrok
force-pushed
the
dynamic-link-sox
branch
10 times, most recently
from
3b89487 to
dae2b57
Compare
mthrok
force-pushed
the
dynamic-link-sox
branch
2 times, most recently
from
92bda56 to
bb14df9
Compare
mthrok
force-pushed
the
dynamic-link-sox
branch
2 times, most recently
from
1f90dc2 to
2988fe9
Compare
mthrok
added a commit
to mthrok/audio
that referenced
this pull request
Jul 25, 2023
In preparation for pytorch#3082 Disable those FFmpeg tests that depend on sox CLI. These tests need to be updated or removed so as not to use sox CLI. Auto-skip some sox tests if decoder/encoder are not available
mthrok
added a commit
to mthrok/audio
that referenced
this pull request
Jul 25, 2023
In preparation for pytorch#3082 Disable those FFmpeg tests that depend on sox CLI. These tests need to be updated or removed so as not to use sox CLI. Auto-skip some sox tests if decoder/encoder are not available
mthrok
added a commit
to mthrok/audio
that referenced
this pull request
Jul 25, 2023
In preparation for pytorch#3082 Disable those FFmpeg tests that depend on sox CLI. These tests need to be updated or removed so as not to use sox CLI. Auto-skip some sox tests if decoder/encoder are not available
mthrok
added a commit
to mthrok/audio
that referenced
this pull request
Jul 25, 2023
In preparation for pytorch#3082 Disable those FFmpeg tests that depend on sox CLI. These tests need to be updated or removed so as not to use sox CLI. Auto-skip some sox tests if decoder/encoder are not available
mthrok
added a commit
to mthrok/audio
that referenced
this pull request
Jul 25, 2023
In preparation for pytorch#3082 Disable those FFmpeg tests that depend on sox CLI. These tests need to be updated or removed so as not to use sox CLI. Auto-skip some sox tests if decoder/encoder are not available
mthrok
added a commit
to mthrok/audio
that referenced
this pull request
Jul 25, 2023
In preparation for pytorch#3082 Disable those FFmpeg tests that depend on sox CLI. These tests need to be updated or removed so as not to use sox CLI. Auto-skip some sox tests if decoder/encoder are not available
facebook-github-bot
pushed a commit
that referenced
this pull request
Jul 25, 2023
Summary: In preparation for #3082 Disable those FFmpeg tests that depend on sox CLI. These tests need to be updated or removed so as not to use sox CLI. Auto-skip some sox tests if decoder/encoder are not available Pull Request resolved: #3494 Differential Revision: D47761948 Pulled By: mthrok fbshipit-source-id: 3a48d7f280f8376a48d223947dd41a7cdc8cbc30
mthrok
force-pushed
the
dynamic-link-sox
branch
3 times, most recently
from
1bcff9f to
52b18f1
Compare
Since libsox and ffmpeg extensions now depend on external libraries, their initialization processes might cause unrecoverable issue, such as segfault. This commit adds environment variable to disable them so that importing torchaudio won't attempt to load these libraries.
|
superseded by #3497, which is simpler |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit changes the way torchaudio integrates libsox.
Previously, libsox has been statically linked and shipped.
This commit changes it so that libsox will be dl-opened at runtime.
Users now need to install libsox separately. Conda users can do so by
conda install -c conda-forge sox libopus. Ubuntu users can useapt install libsox-fmt-allThe notable difference is that the supported formats are different from
one distribution to another, thus some formats will not be available unless users build libsox
with these formats enabled.
If this change causes an unrecoverable issue, one can use
TORCHAUDIO_USE_SOX=0to disablelibsox integration at runtime.