Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor arg mapping in ffmpeg save function #3387

Closed
wants to merge 1 commit into from
Closed

Refactor arg mapping in ffmpeg save function #3387

wants to merge 1 commit into from
+108 −60

Commits on May 31, 2023

  1. Refactor _compat.save function 

    The arguments of TorchAudio's save function ("format", "bits_per_sample" and "encoding")
are not one-to-one mapping to the arguments of FFmpeg encoding.

For example, to use vorbis codec, FFmpeg expects "ogg" container/extension with "vorbis"
encoder. It does not recognize "vorbis" extension like TorchAudio (libsox) does.

This commit refactors the logic to parse/map the arguments.

As a result it now properly works with vorbis and mp3 extension.
    @mthrok
    mthrok committed May 31, 2023
    Configuration menu
    Copy the full SHA
    90061a1 View commit details
    Browse the repository at this point in the history