Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use const reference #3389

Closed
wants to merge 2 commits into from
Closed

Use const reference #3389

wants to merge 2 commits into from

Conversation

mthrok
Copy link
Collaborator

@mthrok mthrok commented May 30, 2023

Summary: Adopt more of const reference in sox source code.

Differential Revision: D46264068

mthrok and others added 2 commits May 29, 2023 21:01
Summary: This commit reduces `torchaudio::sox_*` namespace into `torchaudio::sox`.

Differential Revision: D46257367

fbshipit-source-id: 18c8dbd6e01dd6e35020028d345b22b556c1cebe
Summary: Adopt more of const reference in sox source code.

Differential Revision: D46264068

fbshipit-source-id: d474ba1c9d87c924f3b893fba0ff98ecb412cdc8
@pytorch-bot
Copy link

pytorch-bot bot commented May 30, 2023

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/audio/3389

Note: Links to docs will display an error until the docs builds have been completed.

❌ 2 New Failures

As of commit 393a49f:

NEW FAILURES - The following jobs have failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D46264068

@facebook-github-bot
Copy link
Contributor

This pull request has been merged in 9cdf26f.

@github-actions
Copy link

Hey @None.
You merged this PR, but labels were not properly added. Please add a primary and secondary label (See https://github.com/pytorch/audio/blob/main/.github/process_commit.py).


Some guidance:

Use 'module: ops' for operations under 'torchaudio/{transforms, functional}', and ML-related components under 'torchaudio/csrc' (e.g. RNN-T loss).

Things in "examples" directory:

  • 'recipe' is applicable to training recipes under the 'examples' folder,
  • 'tutorial' is applicable to tutorials under the “examples/tutorials” folder
  • 'example' is applicable to everything else (e.g. C++ examples)
  • 'module: docs' is applicable to code documentations (not to tutorials).
    Regarding examples in code documentations, please also use 'module: docs'.

Please use 'other' tag only when you’re sure the changes are not much relevant to users, or when all other tags are not applicable. Try not to use it often, in order to minimize efforts required when we prepare release notes.


When preparing release notes, please make sure 'documentation' and 'tutorials' occur as the last sub-categories under each primary category like 'new feature', 'improvements' or 'prototype'.

Things related to build are by default excluded from the release note, except when it impacts users. For example:
* Drop support of Python 3.7.
* Add support of Python 3.X.
* Change the way a third party library is bound (so that user needs to install it separately).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants