Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix apply_codec to use named file #3397

Closed
wants to merge 1 commit into from
Closed

Conversation

mthrok
Copy link
Collaborator

@mthrok mthrok commented Jun 1, 2023

Follow-up #3386 The intended change was to use path of temporary file, instead of file-like object

@pytorch-bot
Copy link

pytorch-bot bot commented Jun 1, 2023

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/audio/3397

Note: Links to docs will display an error until the docs builds have been completed.

❌ 5 New Failures

As of commit 15c24e3:

NEW FAILURES - The following jobs have failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot
Copy link
Contributor

@mthrok has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

Summary:
Follow-up pytorch#3386 The intended change was to use path of temporary file, instead of file-like object

Pull Request resolved: pytorch#3397

Reviewed By: hwangjeff

Differential Revision: D46346189

Pulled By: mthrok

fbshipit-source-id: e6bd30c6d749afb0b7505a2955cfac732d0b76f5
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D46346189

@facebook-github-bot
Copy link
Contributor

@mthrok merged this pull request in 1dfac46.

@github-actions
Copy link

github-actions bot commented Jun 1, 2023

Hey @mthrok.
You merged this PR, but labels were not properly added. Please add a primary and secondary label (See https://github.com/pytorch/audio/blob/main/.github/process_commit.py).


Some guidance:

Use 'module: ops' for operations under 'torchaudio/{transforms, functional}', and ML-related components under 'torchaudio/csrc' (e.g. RNN-T loss).

Things in "examples" directory:

  • 'recipe' is applicable to training recipes under the 'examples' folder,
  • 'tutorial' is applicable to tutorials under the “examples/tutorials” folder
  • 'example' is applicable to everything else (e.g. C++ examples)
  • 'module: docs' is applicable to code documentations (not to tutorials).
    Regarding examples in code documentations, please also use 'module: docs'.

Please use 'other' tag only when you’re sure the changes are not much relevant to users, or when all other tags are not applicable. Try not to use it often, in order to minimize efforts required when we prepare release notes.


When preparing release notes, please make sure 'documentation' and 'tutorials' occur as the last sub-categories under each primary category like 'new feature', 'improvements' or 'prototype'.

Things related to build are by default excluded from the release note, except when it impacts users. For example:
* Drop support of Python 3.7.
* Add support of Python 3.X.
* Change the way a third party library is bound (so that user needs to install it separately).

@mthrok mthrok deleted the fix-apply-codec branch June 1, 2023 16:40
@vadimkantorov
Copy link

vadimkantorov commented Jul 4, 2023

Would it be possible to introduce some sort of backend= argument for this function? If I understand, SoX is going to be gradually replaced by ffmpeg in torchaudio, so letting a way for being explicit is a good thing (same as specifying backend for torchaudio.load)

Ah, I see that it's now deprecated in favor of AudioEffector which only supports ffmpeg: #3386

If still SoX has useful effects/codecs, adding explicit backend= option to AudioEffector would be great

@mthrok
Copy link
Collaborator Author

mthrok commented Jul 6, 2023

If still SoX has useful effects/codecs, adding explicit backend= option to AudioEffector would be great

The syntax and semantics of those sox effect chain and FFmpeg's filter graph are different, so unifying them is not straightforward. I think users can create such wrapper that suit their requirement and constraints if necessary.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants