-
Notifications
You must be signed in to change notification settings - Fork 654
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix apply_codec to use named file #3397
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/audio/3397
Note: Links to docs will display an error until the docs builds have been completed. ❌ 5 New FailuresAs of commit 15c24e3: NEW FAILURES - The following jobs have failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
@mthrok has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Summary: Follow-up pytorch#3386 The intended change was to use path of temporary file, instead of file-like object Pull Request resolved: pytorch#3397 Reviewed By: hwangjeff Differential Revision: D46346189 Pulled By: mthrok fbshipit-source-id: e6bd30c6d749afb0b7505a2955cfac732d0b76f5
This pull request was exported from Phabricator. Differential Revision: D46346189 |
Hey @mthrok. Some guidance:Use 'module: ops' for operations under 'torchaudio/{transforms, functional}', and ML-related components under 'torchaudio/csrc' (e.g. RNN-T loss). Things in "examples" directory:
Please use 'other' tag only when you’re sure the changes are not much relevant to users, or when all other tags are not applicable. Try not to use it often, in order to minimize efforts required when we prepare release notes. When preparing release notes, please make sure 'documentation' and 'tutorials' occur as the last sub-categories under each primary category like 'new feature', 'improvements' or 'prototype'. Things related to build are by default excluded from the release note, except when it impacts users. For example: |
Would it be possible to introduce some sort of Ah, I see that it's now deprecated in favor of AudioEffector which only supports ffmpeg: #3386 If still SoX has useful effects/codecs, adding explicit |
The syntax and semantics of those sox effect chain and FFmpeg's filter graph are different, so unifying them is not straightforward. I think users can create such wrapper that suit their requirement and constraints if necessary. |
Follow-up #3386 The intended change was to use path of temporary file, instead of file-like object