Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean-up ComputeKaldiPitch residue #3403

Closed
wants to merge 1 commit into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,6 @@ python setup.py develop
Some environmnet variables that change the build behavior
- `BUILD_SOX`: Deteremines whether build and bind libsox in non-Windows environments. (no effect in Windows as libsox integration is not available) Default value is 1 (build and bind). Use 0 for disabling it.
- `USE_CUDA`: Determines whether build the custom CUDA kernel. Default to the availability of CUDA-compatible GPUs.
- `BUILD_KALDI`: Determines whether build Kaldi extension. This is required for `kaldi_pitch` function. Default value is 1 on Linux/macOS and 0 on Windows.
- `BUILD_RNNT`: Determines whether build RNN-T loss function. Default value is 1.
- `BUILD_CUDA_CTC_DECODER`: Determines whether build decoder features based on CUDA CTC decoder. Default value is 1. (`USE_CUDA` has to be 1.)

Expand Down
1 change: 0 additions & 1 deletion docs/source/functional.rst
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,6 @@ Feature Extractions
compute_deltas
detect_pitch_frequency
sliding_window_cmn
compute_kaldi_pitch
spectral_centroid

Multi-channel
Expand Down
2 changes: 0 additions & 2 deletions tools/setup_helpers/extension.py
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,6 @@ def _get_build(var, default=False):


_BUILD_SOX = False if platform.system() == "Windows" else _get_build("BUILD_SOX", True)
_BUILD_KALDI = False if platform.system() == "Windows" else _get_build("BUILD_KALDI", True)
_BUILD_RIR = _get_build("BUILD_RIR", True)
_BUILD_RNNT = _get_build("BUILD_RNNT", True)
_USE_FFMPEG = _get_build("USE_FFMPEG", False)
Expand Down Expand Up @@ -117,7 +116,6 @@ def build_extension(self, ext):
"-DCMAKE_VERBOSE_MAKEFILE=ON",
f"-DPython_INCLUDE_DIR={distutils.sysconfig.get_python_inc()}",
f"-DBUILD_SOX:BOOL={'ON' if _BUILD_SOX else 'OFF'}",
f"-DBUILD_KALDI:BOOL={'ON' if _BUILD_KALDI else 'OFF'}",
f"-DBUILD_RIR:BOOL={'ON' if _BUILD_RIR else 'OFF'}",
f"-DBUILD_RNNT:BOOL={'ON' if _BUILD_RNNT else 'OFF'}",
f"-DBUILD_ALIGN:BOOL={'ON' if _BUILD_ALIGN else 'OFF'}",
Expand Down
93 changes: 0 additions & 93 deletions torchaudio/csrc/kaldi.cpp

This file was deleted.

1 change: 0 additions & 1 deletion torchaudio/csrc/pybind/pybind.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,6 @@ namespace torchaudio {
namespace {

PYBIND11_MODULE(_torchaudio, m) {
m.def("is_kaldi_available", &is_kaldi_available, "");
m.def("is_rir_available", &is_rir_available, "");
m.def("is_align_available", &is_align_available, "");
m.def("cuda_version", &cuda_version, "");
Expand Down
8 changes: 0 additions & 8 deletions torchaudio/csrc/utils.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -7,14 +7,6 @@

namespace torchaudio {

bool is_kaldi_available() {
#ifdef INCLUDE_KALDI
return true;
#else
return false;
#endif
}

bool is_rir_available() {
#ifdef INCLUDE_RIR
return true;
Expand Down
1 change: 0 additions & 1 deletion torchaudio/csrc/utils.h
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@
#include <torch/torch.h>

namespace torchaudio {
bool is_kaldi_available();
bool is_rir_available();
bool is_align_available();
c10::optional<int64_t> cuda_version();
Expand Down