Fix CUDA 12.5 build #3811
Fix CUDA 12.5 build #3811
Conversation
CUDA 12.5 removed the FLT_MAX symbol. This was previously used without being explicitly imported. FLT_MAX is defined in <float.h>, including this header fixes the issue
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/audio/3811
Note: Links to docs will display an error until the docs builds have been completed. This comment was automatically generated by Dr. CI and updates every 15 minutes. |
|
Hi @HennerM! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks! |
|
@atalman do you mind having a look at this? I can't build Torchaudio on CUDA 12.5 without this fix in, thanks |
CUDA 12.5 removed the FLT_MAX symbol.
This was previously used without being explicitly imported. FLT_MAX is defined in <float.h>, including this header fixes the issue.
PLEASE NOTE THAT THE TORCHAUDIO REPOSITORY IS NO LONGER ACTIVELY MONITORED. You may not get a response. For open discussions, visit https://discuss.pytorch.org/.
A similar issue has been reported in Kaldi before: kaldi-asr/kaldi#4914