Do not use SoxEffectsChain in sox compatibility test #781
Conversation
|
|
||
| self.assertEqual(waveform_dithered_noiseshaped, sox_dither_waveform_ns, atol=1e-02, rtol=1e-5) | ||
|
|
||
| def test_vctk_transform_pipeline(self): |
There was a problem hiding this comment.
This test has been removed because it does not test anything new.
channels and rate effects are no effect because the input file is already one channel with 16k Hz, then the remaining effect is gain -h gain -rh dither -s, but applying gain twice does not make sense (sox command returns error) and dither is tested separately.
|
Resolved The tests failing on macOS has nothing to do with this PR, and is addressed at #782 . |
mthrok
force-pushed
the
replace-test-sox-effects
branch
from
44f158a to
0eb436b
Compare
Codecov Report
@@ Coverage Diff @@
## master #781 +/- ##
==========================================
- Coverage 89.53% 89.49% -0.04%
==========================================
Files 32 32
Lines 2617 2617
==========================================
- Hits 2343 2342 -1
- Misses 274 275 +1
Continue to review full report at Codecov.
|
| """ | ||
| Test biquad lowpass filter, compare to SoX implementation | ||
| """ |
There was a problem hiding this comment.
nit: Why is the description removed?
There was a problem hiding this comment.
Because all the tests in the class have the same description. It's redundant and does not carry new useful information.
|
Thanks |
This PR replaces
torchaudio.sox_effects.SoxEffectsChainintest_sox_compatibilitywith baresoxcommand.The parity of
torchaudio.sox_effects.SoxEffectsChainagainstsoxcommand is not tested and it has known issues #771, therefore it is not appropriate to use this class for testing other functions.