Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add deprecation warnings to libsox specific functions #975

Merged
merged 1 commit into from
Oct 26, 2020
Merged

Add deprecation warnings to libsox specific functions #975

merged 1 commit into from
Oct 26, 2020

Conversation

mthrok
Copy link
Collaborator

@mthrok mthrok commented Oct 21, 2020

Note: this should also go to master branch.

@mthrok mthrok mentioned this pull request Oct 21, 2020
Closed
vincentqb
vincentqb approved these changes Oct 21, 2020
View reviewed changes
Copy link
Contributor

@vincentqb vincentqb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I'd suggest adding a little bit of missing information to #903.

torchaudio/backend/sox_backend.py Show resolved Hide resolved
torchaudio/backend/sox_backend.py Show resolved Hide resolved
torchaudio/backend/sox_backend.py Show resolved Hide resolved
torchaudio/backend/sox_backend.py Show resolved Hide resolved
torchaudio/backend/sox_backend.py Show resolved Hide resolved
torchaudio/backend/sox_backend.py Show resolved Hide resolved
@mthrok mthrok changed the base branch from release/0.7 to master October 26, 2020 17:12
@mthrok mthrok merged commit 0f80bcf into pytorch:master Oct 26, 2020
@mthrok mthrok deleted the deprecation branch October 26, 2020 17:57
mthrok pushed a commit to mthrok/audio that referenced this pull request Feb 26, 2021
@Superhzf
update how add_ method is used in char_rnn_* tuutorials to avoid warn…
4cbbacd 
…ings (pytorch#975)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vincentqb vincentqb vincentqb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mthrok @vincentqb