Skip to content

[torch-nightly] Add v3 score field #1538

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 7 commits into from
Closed

[torch-nightly] Add v3 score field #1538

wants to merge 7 commits into from

Conversation

xuzhao9
Copy link
Contributor

@xuzhao9 xuzhao9 commented Apr 7, 2023 •
edited
Loading

Add v3 score field to the torch-nightly test.

Test plan:

$ python run_benchmark.py torch-nightly -c v3-cuda-tests.yaml --score ~/work/tb-v3/nightly/metrics-20230407145303.json
TorchBench score: 1000.0.

After changing the test latency to a larger value:

$ python run_benchmark.py torch-nightly -c v3-cuda-tests.yaml --score ~/work/tb-v3/nightly/metrics-20230407145303-larger.json
TorchBench score: 992.4067135827728.

After changing the test latency to a smaller value:

$ python run_benchmark.py torch-nightly -c v3-cuda-tests.yaml --score ~/work/tb-v3/nightly/metrics-20230407145303-smaller.json
TorchBench score: 1024.4664975604358.

@xuzhao9 xuzhao9 requested a review from weiwangmeta April 7, 2023 17:32
@xuzhao9 xuzhao9 changed the title Add v3 score field to the test [torch-nightly] Add v3 score field Apr 7, 2023
@facebook-github-bot
Copy link
Contributor

@xuzhao9 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@xuzhao9 xuzhao9 mentioned this pull request Apr 7, 2023
Closed
6 tasks
@facebook-github-bot
Copy link
Contributor

@xuzhao9 merged this pull request in 90f07fd.

@xuzhao9 xuzhao9 deleted the xz9/add-v3-score branch April 7, 2023 19:34
cclauss pushed a commit to cclauss/benchmark that referenced this pull request Jan 22, 2025
@dmah42 @buster3 @dominichamon
fix pytorch#1446 by removing the address operator (pytorch#1538)
ff8d44c 
* fix pytorch#1446 by removing the address operator

* add test

* format

---------

Co-authored-by: Thomas <thomas.maierbacher@rohde-schwarz.com>
Co-authored-by: Dominic Hamon <dominichamon@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@weiwangmeta weiwangmeta Awaiting requested review from weiwangmeta

Assignees
No one assigned
Labels
cla signed Merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@xuzhao9 @facebook-github-bot