Skip to content

Commit

Permalink
Don't allow unused **kwargs in input_constructors except for a define…
Browse files Browse the repository at this point in the history
…d set of exceptions (#1872)

Summary:
Pull Request resolved: #1872

[x] Remove unused arguments from input constructors and related functions. The idea is especially not to let unused keyword arguments disappear into `**kwargs` and be silently ignored
[x] add arguments to some input constructors so they don't need any `**kwargs`
[x] Add a decorator that ensures that each input constructor can accept a certain set of keyword arguments, even if those are not used are the constructor, while still erroring on
[ ] Prevent arguments from having different defaults in the input constructors as in acquisition functions

Reviewed By: SebastianAment

Differential Revision: D46519588

fbshipit-source-id: 81049c245489ceb6379a12a7e6d5ca9a6cd74898
  • Loading branch information
esantorella authored and facebook-github-bot committed Jun 7, 2023
1 parent 667b2eb commit d139a84
Show file tree
Hide file tree
Showing 3 changed files with 177 additions and 110 deletions.
Loading

0 comments on commit d139a84

Please sign in to comment.