Detach fval in torch_minimize to avoid memory leak

pytorch · Sep 11, 2024 · d974542 · d974542
1 parent 4d49bf7
commit d974542
Showing 1 changed file with 1 addition and 1 deletion.
diff --git a/botorch/optim/core.py b/botorch/optim/core.py
@@ -202,7 +202,7 @@ def torch_minimize(
         )
 
         # TODO: Update stopping_criterion API to return a message.
-        if stopping_criterion and stopping_criterion(fval):
+        if stopping_criterion and stopping_criterion(fval.detach()):
             result.status = OptimizationStatus.STOPPED
             result.message = "`torch_minimize` stopped due to `stopping_criterion`."