pass gen_candidates callable in optimize_acqf #1655
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D41629164 |
sdaulton
force-pushed
the
export-D41629164
branch
from
3b9906f to
f692120
Compare
sdaulton
added a commit
to sdaulton/botorch
that referenced
this pull request
Feb 6, 2023
Summary: Pull Request resolved: pytorch#1655 see title. This will support using stochastic optimization Differential Revision: D41629164 fbshipit-source-id: 0f31bdc3392f47546da31183fa2166bf18ec174b
|
This pull request was exported from Phabricator. Differential Revision: D41629164 |
Summary: Pull Request resolved: pytorch#1655 see title. This will support using stochastic optimization Reviewed By: esantorella Differential Revision: D41629164 fbshipit-source-id: e066e4eb4314803f8925e549f998d9d2ccdd55be
|
This pull request was exported from Phabricator. Differential Revision: D41629164 |
sdaulton
force-pushed
the
export-D41629164
branch
from
f692120 to
a675a84
Compare
Codecov Report
@@ Coverage Diff @@
## main #1655 +/- ##
=======================================
Coverage 99.99% 99.99%
=======================================
Files 166 166
Lines 14360 14368 +8
=======================================
+ Hits 14359 14367 +8
Misses 1 1
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
sdaulton
added a commit
to sdaulton/botorch
that referenced
this pull request
Feb 8, 2023
Summary: Pull Request resolved: pytorch#1655 see title. This will support using stochastic optimization Differential Revision: https://internalfb.com/D41629164 fbshipit-source-id: f257565ebd2f8ad999fc8f527da2f870cf654d72
sdaulton
added a commit
to sdaulton/botorch
that referenced
this pull request
Feb 8, 2023
Summary: Pull Request resolved: pytorch#1655 see title. This will support using stochastic optimization Differential Revision: https://internalfb.com/D41629164 fbshipit-source-id: 41f47c7dcb2d8a1cb586edc0d05a4e41d472f8e4
sdaulton
added a commit
to sdaulton/botorch
that referenced
this pull request
Feb 8, 2023
Summary: Pull Request resolved: pytorch#1655 see title. This will support using stochastic optimization Differential Revision: https://internalfb.com/D41629164 fbshipit-source-id: 309cf9d46454f760448069a374212585d70da6e5
sdaulton
added a commit
to sdaulton/botorch
that referenced
this pull request
Feb 8, 2023
Summary: Pull Request resolved: pytorch#1655 see title. This will support using stochastic optimization Differential Revision: https://internalfb.com/D41629164 fbshipit-source-id: 9f2f16da5f4ea97ac3ff974539a5558c9342e6eb
sdaulton
added a commit
to sdaulton/botorch
that referenced
this pull request
Feb 8, 2023
Summary: Pull Request resolved: pytorch#1655 see title. This will support using stochastic optimization Differential Revision: https://internalfb.com/D41629164 fbshipit-source-id: 6db9499cff12e54393968246c7344af0820e5a40
|
This pull request has been merged in 89f923d. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: see title. This will support using stochastic optimization
Differential Revision: D41629164