Make some tensors buffers in pathwise sampling code #1821
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
@Balandat has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Balandat
force-pushed
the
fix_sample_path_dev_transfer
branch
from
b320204
to
e057876
Compare
|
@Balandat has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Codecov Report
@@ Coverage Diff @@
## main #1821 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 170 170
Lines 14911 14915 +4
=========================================
+ Hits 14911 14915 +4
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Fixes an issue when moving a SamplePath from GPU to GPU reported in pytorch#1820
Balandat
force-pushed
the
fix_sample_path_dev_transfer
branch
from
e057876
to
0ad2cfb
Compare
|
@Balandat has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes an issue when moving a SamplePath from GPU to GPU.
I wasn't super thorough to go through all of the code and every eventuality, but this at least makes the issue reported in #1820 go away.