Loopifying conditional kwarg processing in _optimize_acqf_batch
#1923
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D47297929 |
esantorella
approved these changes
Jul 10, 2023
botorch/optim/optimize.py
Outdated
Comment on lines
313
to
314
| if getattr(opt_inputs, constraint_name) is not None: | ||
| gen_kwargs[constraint_name] = getattr(opt_inputs, constraint_name) |
There was a problem hiding this comment.
This is probably a bad idea since it doesn't work for Python < 3.8, but...
Suggested change
| if getattr(opt_inputs, constraint_name) is not None: | |
| gen_kwargs[constraint_name] = getattr(opt_inputs, constraint_name) | |
| if (constraint := getattr(opt_inputs, constraint_name)) is not None: | |
| gen_kwargs[constraint_name] = constraint |
There was a problem hiding this comment.
Nice! The main botorch readme lists Python >= 3.8 as a requirement, should be fine :)
SebastianAment
added a commit
to SebastianAment/botorch
that referenced
this pull request
Jul 10, 2023
…torch#1923) Summary: Pull Request resolved: pytorch#1923 Small code simplification, pattern could be reused elsewhere for `kwarg` processing, particularly where a number of fields have to be check. Reviewed By: esantorella Differential Revision: D47297929 fbshipit-source-id: 6cf9aa8ecb1248512d298ee792e4804dc60bcd3f
SebastianAment
force-pushed
the
export-D47297929
branch
from
d773740
to
348392b
Compare
|
This pull request was exported from Phabricator. Differential Revision: D47297929 |
…torch#1923) Summary: Pull Request resolved: pytorch#1923 Small code simplification, pattern could be reused elsewhere for `kwarg` processing, particularly where a number of fields have to be check. Reviewed By: esantorella Differential Revision: D47297929 fbshipit-source-id: 27df69a4aa87fb3f8d8c1f0a42b7d8e4bdd3c8c2
|
This pull request was exported from Phabricator. Differential Revision: D47297929 |
SebastianAment
force-pushed
the
export-D47297929
branch
from
348392b
to
be57b36
Compare
|
This pull request has been merged in 1d077c9. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: Small code simplification, pattern could be reused elsewhere for
kwargprocessing, particularly where a number of fields have to be check.Differential Revision: D47297929