Fix memory leak in FullyBayesianPosterior #1951
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: The existance of `_quantile` method that references the object seems to cause a weird memory leak when `model.posterior` is called in a loop. Making `_quantile` a standalone function fixes this. We lose the caching functionality but I think that's a fair trade. Differential Revision: D47821429 fbshipit-source-id: 863c084363b4b5e745f238a8145971bf5ece692c
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D47821429 |
Codecov Report
@@ Coverage Diff @@
## main #1951 +/- ##
=======================================
Coverage 99.94% 99.94%
=======================================
Files 177 177
Lines 15693 15691 -2
=======================================
- Hits 15685 15683 -2
Misses 8 8
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
This pull request has been merged in 793c3bd. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: The existance of
_quantilemethod that references the object seems to cause a weird memory leak whenmodel.posterioris called in a loop. Making_quantilea standalone function fixes this. We lose the caching functionality but I think that's a fair trade.Differential Revision: D47821429