-
Notifications
You must be signed in to change notification settings - Fork 404
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hack around missing pytorch 1.13.1 binaries for py3.11 on mac #1966
Conversation
…ac for py3.11 in CI
I think you need to do this for the deploy_on_release workflow as well: https://github.com/pytorch/botorch/blob/main/.github/workflows/deploy_on_release.yml |
I don't think so, we don't pin to the specific torch version there, so it should just install 2.0.1 for that one |
Yeah, that makes more sense :D |
Codecov Report
@@ Coverage Diff @@
## main #1966 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 178 178
Lines 15748 15748
=========================================
Hits 15748 15748 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Pushing the changes to https://github.com/pytorch/botorch/tree/no_mac_py311_ci to test it in the workflows. For some reason it's not picking up the new min_torch_version assignment - not sure what's going on I'll try a few things. |
Updated, newest version tested here: https://github.com/pytorch/botorch/actions/runs/5733147831 |
@Balandat has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
This fix is needed to avoid errors in the CI