Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hack around missing pytorch 1.13.1 binaries for py3.11 on mac #1966

Closed
wants to merge 2 commits into from

Conversation

Balandat
Copy link
Contributor

@Balandat Balandat commented Aug 1, 2023

This fix is needed to avoid errors in the CI

@facebook-github-bot facebook-github-bot added the CLA Signed Do not delete this pull request or issue due to inactivity. label Aug 1, 2023
@saitcakmak
Copy link
Contributor

I think you need to do this for the deploy_on_release workflow as well: https://github.com/pytorch/botorch/blob/main/.github/workflows/deploy_on_release.yml

@Balandat
Copy link
Contributor Author

Balandat commented Aug 1, 2023

I don't think so, we don't pin to the specific torch version there, so it should just install 2.0.1 for that one

@saitcakmak
Copy link
Contributor

Yeah, that makes more sense :D

@codecov
Copy link

codecov bot commented Aug 1, 2023

Codecov Report

Merging #1966 (23c71f1) into main (3b674eb) will not change coverage.
The diff coverage is n/a.

❗ Current head 23c71f1 differs from pull request most recent head 64e79f4. Consider uploading reports for the commit 64e79f4 to get more accurate results

@@            Coverage Diff            @@
##              main     #1966   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          178       178           
  Lines        15748     15748           
=========================================
  Hits         15748     15748           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@Balandat
Copy link
Contributor Author

Balandat commented Aug 1, 2023

Pushing the changes to https://github.com/pytorch/botorch/tree/no_mac_py311_ci to test it in the workflows. For some reason it's not picking up the new min_torch_version assignment - not sure what's going on I'll try a few things.

@Balandat
Copy link
Contributor Author

Balandat commented Aug 2, 2023

Updated, newest version tested here: https://github.com/pytorch/botorch/actions/runs/5733147831

@facebook-github-bot
Copy link
Contributor

@Balandat has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

@Balandat merged this pull request in 85cec4c.

@Balandat Balandat deleted the no_mac_py311_ci branch March 5, 2024 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Do not delete this pull request or issue due to inactivity. Merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants