Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding qLogNEHVI to acquisition factory #2051

Closed
wants to merge 3 commits into from
Closed

Adding qLogNEHVI to acquisition factory #2051

wants to merge 3 commits into from

Conversation

SebastianAment
Copy link
Contributor

Summary: This commit introduces qLogNEHVI to the get_acquisition_function factory and reduces code duplication.

Differential Revision: D50386440

@facebook-github-bot facebook-github-bot added the CLA Signed Do not delete this pull request or issue due to inactivity. label Oct 17, 2023
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D50386440

@codecov
Copy link

codecov bot commented Oct 17, 2023 •
edited
Loading

Codecov Report

Merging #2051 (c79bde3) into main (e0f10a3) will not change coverage.
The diff coverage is 100.00%.

❗ Current head c79bde3 differs from pull request most recent head 38e73ae. Consider uploading reports for the commit 38e73ae to get more accurate results

@@            Coverage Diff            @@
##              main     #2051   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          179       179           
  Lines        15818     15844   +26     
=========================================
+ Hits         15818     15844   +26
Files Coverage Δ
botorch/acquisition/factory.py 100.00% <100.00%> (ø)
botorch/acquisition/input_constructors.py 100.00% <100.00%> (ø)
botorch/acquisition/multi_objective/logei.py 100.00% <100.00%> (ø)
botorch/acquisition/multi_objective/monte_carlo.py 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D50386440

SebastianAment added a commit to SebastianAment/botorch that referenced this pull request Oct 17, 2023
@SebastianAment @facebook-github-bot
Adding qLogNEHVI to acquisition factory (pytorch#2051)
6a73fa5 
Summary:
Pull Request resolved: pytorch#2051

This commit introduces `qLogNEHVI` to the `get_acquisition_function` factory and reduces code duplication.

Differential Revision: D50386440

fbshipit-source-id: ca971eaf8711b806131f21c5405ac56ccff50263
SebastianAment added a commit to SebastianAment/botorch that referenced this pull request Oct 18, 2023
@SebastianAment @facebook-github-bot
Adding qLogNEHVI to acquisition factory (pytorch#2051)
cf76326 
Summary:

This commit introduces `qLogNEHVI` to the `get_acquisition_function` factory and reduces code duplication.

Differential Revision: D50386440
SebastianAment added a commit to SebastianAment/botorch that referenced this pull request Oct 18, 2023
@SebastianAment @facebook-github-bot
Adding qLogNEHVI to acquisition factory (pytorch#2051)
5efe1b4 
Summary:

This commit introduces `qLogNEHVI` to the `get_acquisition_function` factory and reduces code duplication.

Differential Revision: D50386440
SebastianAment added a commit to SebastianAment/botorch that referenced this pull request Oct 18, 2023
@SebastianAment @facebook-github-bot
Adding qLogNEHVI to acquisition factory (pytorch#2051)
de714a1 
Summary:

This commit introduces `qLogNEHVI` to the `get_acquisition_function` factory and reduces code duplication.

Differential Revision: D50386440
SebastianAment added a commit to SebastianAment/botorch that referenced this pull request Oct 18, 2023
@SebastianAment @facebook-github-bot
Adding qLogNEHVI to acquisition factory (pytorch#2051)
6205259 
Summary:

This commit introduces `qLogNEHVI` to the `get_acquisition_function` factory and reduces code duplication.

Differential Revision: D50386440
SebastianAment added a commit to SebastianAment/botorch that referenced this pull request Oct 18, 2023
@SebastianAment @facebook-github-bot
Adding qLogNEHVI to acquisition factory (pytorch#2051)
590baac 
Summary:

This commit introduces `qLogNEHVI` to the `get_acquisition_function` factory and reduces code duplication.

Differential Revision: D50386440
SebastianAment added a commit to SebastianAment/botorch that referenced this pull request Oct 23, 2023
@SebastianAment @facebook-github-bot
Adding qLogNEHVI to acquisition factory (pytorch#2051)
e5dc46c 
Summary:

This commit introduces `qLogNEHVI` to the `get_acquisition_function` factory and reduces code duplication.

Reviewed By: Balandat, esantorella

Differential Revision: D50386440
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D50386440

SebastianAment added a commit to SebastianAment/botorch that referenced this pull request Oct 24, 2023
@SebastianAment @facebook-github-bot
Adding qLogNEHVI to acquisition factory (pytorch#2051)
6698fb3 
Summary:

This commit introduces `qLogNEHVI` to the `get_acquisition_function` factory and reduces code duplication.

Reviewed By: Balandat, esantorella

Differential Revision: D50386440
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D50386440

SebastianAment added a commit to SebastianAment/botorch that referenced this pull request Oct 24, 2023
@SebastianAment @facebook-github-bot
Adding qLogNEHVI to acquisition factory (pytorch#2051)
844f6db 
Summary:

This commit introduces `qLogNEHVI` to the `get_acquisition_function` factory and reduces code duplication.

Reviewed By: Balandat, esantorella

Differential Revision: D50386440
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D50386440

SebastianAment added a commit to SebastianAment/botorch that referenced this pull request Oct 24, 2023
@SebastianAment @facebook-github-bot
Adding qLogNEHVI to acquisition factory (pytorch#2051)
b3ab037 
Summary:

This commit introduces `qLogNEHVI` to the `get_acquisition_function` factory and reduces code duplication.

Reviewed By: Balandat, esantorella

Differential Revision: D50386440
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D50386440

@SebastianAment @facebook-github-bot
qLogNEHVI (pytorch#2046)
8367072 
Summary:

This commit introduces the Monte Carlo noisy hyper-volume improvement variant of the LogEI family of acquisition functions.

Reviewed By: Balandat

Differential Revision: D50046979
@SebastianAment @facebook-github-bot
qLogNEHVI's input constructor (pytorch#2048)
a9f321c 
Summary:

This commit adds qLogNEHVI's input constructor, enabling integration with Ax in a follow up diff.

Reviewed By: saitcakmak, Balandat

Differential Revision: D50345278
@SebastianAment @facebook-github-bot
Adding qLogNEHVI to acquisition factory (pytorch#2051)
38e73ae 
Summary:

This commit introduces `qLogNEHVI` to the `get_acquisition_function` factory and reduces code duplication.

Reviewed By: Balandat, esantorella

Differential Revision: D50386440
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D50386440

@facebook-github-bot
Copy link
Contributor

This pull request has been merged in 58da970.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
CLA Signed Do not delete this pull request or issue due to inactivity. fb-exported Merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SebastianAment @facebook-github-bot