Move MacOS CI to M1 runners #2225
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
Balandat
commented
Feb 27, 2024
|
Also, looks like py3.9 is not supported on |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2225 +/- ##
=======================================
Coverage 99.87% 99.87%
=======================================
Files 188 188
Lines 16744 16744
=======================================
Hits 16723 16723
Misses 21 21 ☔ View full report in Codecov by Sentry. |
|
Hmm, interesting test failure here, can't repro this on my M1 laptop. May just adjust the tolerances a bit here. |
Pytorch is planning to stop nightly builds for Intel Macs: pytorch/pytorch#114602 This PR updates the mac runners to `macos-14`, which is the only public GHA runner for Mac M1s: https://docs.github.com/en/actions/using-github-hosted-runners/about-github-hosted-runners/about-github-hosted-runners#standard-github-hosted-runners-for-private-repositories
This was rather aggressive, and apparently the numerics on the macos-14 runner are slightly different.
Balandat
commented
Mar 3, 2024
Comment on lines
+390
to
+391
| atol = 1e-7 if dtype == torch.double else 3e-7 | ||
| rtol = 1e-4 if dtype == torch.double else 4e-4 |
There was a problem hiding this comment.
Updated these; they were rather tight, and apparently the numerics on the macos-14 runner are slightly different so that this ended up failing without these changes.
|
@Balandat has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pytorch is planning to stop nightly builds for Intel Macs: pytorch/pytorch#114602
This PR updates the mac runners to
macos-14, which is the only public GHA runner for Mac M1s: https://docs.github.com/en/actions/using-github-hosted-runners/about-github-hosted-runners/about-github-hosted-runners#standard-github-hosted-runners-for-private-repositoriesNote: Python 3.9 is not available on the
macos-14runners, so testing on py3.9 is disabled on those by excluding that combo from the test matrix. Once we bump up the minimum supported python version to 3.10 we can remove this added complexity.