make qNIPV not an AnalyticAcquisitionFunction; optimize_acqf support clarity
#2286
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D55843171 |
…t clarity (pytorch#2286) Summary: I put a `LogExpectedImprovement` instance into `optimize_acqf`, and when I got an error about it not having an attribute `X_pending`, I was not sure if this was a bug or if I did something known to be unsupported. - Make `qNegIntegratedPosteriorVariance` inherit from `AcquisitionFunction` rather than `AnalyticAcquisitionFunction`, because the functionality it was inheriting from `AnalyticAcquisitionFunction` was not relevant. - `qNegIntegratedPosteriorVariance` loses an error message about not supporting multi-output with a `PosteriorTransform` that is not scalarized and gains a unit test showing that it does. Differential Revision: D55843171
esantorella
force-pushed
the
export-D55843171
branch
from
ec02d45 to
0da045b
Compare
|
This pull request was exported from Phabricator. Differential Revision: D55843171 |
esantorella
added a commit
to esantorella/botorch
that referenced
this pull request
Apr 6, 2024
…t clarity (pytorch#2286) Summary: I put a `LogExpectedImprovement` instance into `optimize_acqf`, and when I got an error about it not having an attribute `X_pending`, I was not sure if this was a bug or if I did something known to be unsupported. - Make `qNegIntegratedPosteriorVariance` inherit from `AcquisitionFunction` rather than `AnalyticAcquisitionFunction`, because the functionality it was inheriting from `AnalyticAcquisitionFunction` was not relevant. - `qNegIntegratedPosteriorVariance` loses an error message about not supporting multi-output with a `PosteriorTransform` that is not scalarized and gains a unit test showing that it does. Differential Revision: D55843171
esantorella
added a commit
to esantorella/botorch
that referenced
this pull request
Apr 6, 2024
…t clarity (pytorch#2286) Summary: I put a `LogExpectedImprovement` instance into `optimize_acqf`, and when I got an error about it not having an attribute `X_pending`, I was not sure if this was a bug or if I did something known to be unsupported. - Make `qNegIntegratedPosteriorVariance` inherit from `AcquisitionFunction` rather than `AnalyticAcquisitionFunction`, because the functionality it was inheriting from `AnalyticAcquisitionFunction` was not relevant. - `qNegIntegratedPosteriorVariance` loses an error message about not supporting multi-output with a `PosteriorTransform` that is not scalarized and gains a unit test showing that it does. Differential Revision: D55843171
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2286 +/- ##
=======================================
Coverage 99.97% 99.97%
=======================================
Files 197 197
Lines 17151 17152 +1
=======================================
+ Hits 17147 17148 +1
Misses 4 4 ☔ View full report in Codecov by Sentry. |
|
This pull request has been merged in e8cbbae. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
I put a
LogExpectedImprovementinstance intooptimize_acqf, and when I got an error about it not having an attributeX_pending, I was not sure if this was a bug or if I did something known to be unsupported.qNegIntegratedPosteriorVarianceinherit fromAcquisitionFunctionrather thanAnalyticAcquisitionFunction, because the functionality it was inheriting fromAnalyticAcquisitionFunctionwas not relevant.qNegIntegratedPosteriorVarianceloses an error message about not supporting multi-output with aPosteriorTransformthat is not scalarized and gains a unit test showing that it does.Differential Revision: D55843171