Use codecov github action for uploading coverage #2312
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
@saitcakmak has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2312 +/- ##
=======================================
Coverage 99.97% 99.97%
=======================================
Files 197 197
Lines 17181 17181
=======================================
Hits 17177 17177
Misses 4 4 ☔ View full report in Codecov by Sentry. |
|
@saitcakmak merged this pull request in b17caf5. |
facebook-github-bot
pushed a commit
to facebook/Ax
that referenced
this pull request
Apr 30, 2024
Summary: Replicates pytorch/botorch#2312 Codecov bash uploader is marked for deprecation: https://docs.codecov.com/docs/about-the-codecov-bash-uploader Switching the CI to use the codecov github action with the newly added upload token: https://github.com/marketplace/actions/codecov Pull Request resolved: #2406 Test Plan: Check for successful upload in CI signals Reviewed By: dme65 Differential Revision: D56713216 Pulled By: saitcakmak fbshipit-source-id: c5d70e0d4a362e61788ed54b73605786bd5b4f08
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Codecov bash uploader is marked for deprecation: https://docs.codecov.com/docs/about-the-codecov-bash-uploader
Switching the CI to use the codecov github action with the newly added upload token: https://github.com/marketplace/actions/codecov
Test Plan:
Successfully uploaded https://app.codecov.io/github/pytorch/botorch/commit/6155e7425ad5327b2d9a13a156bb65ecc0c199f3
from https://github.com/pytorch/botorch/actions/runs/8882788744/job/24388210462