Require PyTorch>=2.0.1, GPyTorch==1.13 and linear_operator==0.5.3 #2511
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
@saitcakmak has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2511 +/- ##
=======================================
Coverage 99.98% 99.98%
=======================================
Files 193 193
Lines 16941 16941
=======================================
Hits 16939 16939
Misses 2 2 ☔ View full report in Codecov by Sentry. |
esantorella
reviewed
Sep 6, 2024
| @@ -62,8 +62,6 @@ jobs: | |||
| python setup.py egg_info | |||
| req_txt="botorch.egg-info/requires.txt" | |||
| min_torch_version=$(grep '\btorch[>=]=' ${req_txt} | sed 's/[^0-9.]//g') | |||
| # HACK around the fact that pytorch does not offer a mac binary for 1.13.1 for py3.11 - TODO: Remove when bumping torch to 2.0.1 | |||
There was a problem hiding this comment.
Thanks for catching this! Do you know if there's a reason it's specifying 2.0.1 rather than 2.0? I guess it's fine if this flow passes.
esantorella
approved these changes
Sep 6, 2024
saitcakmak
changed the title
|
@saitcakmak has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
@saitcakmak merged this pull request in 16853b4. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As titled.
Also includes some updates to test against stable workflow to make it pass.
Test plan: https://github.com/pytorch/botorch/actions/runs/10751171192