Skip to content

Commit

Permalink
[Validations] Add option to use meta cdn for pypi index (#1999)
Browse files Browse the repository at this point in the history
* [Validations] Add option to use meta cdn for pypi index

* fix

* test
  • Loading branch information
atalman authored Sep 27, 2024
1 parent 89d9a8c commit 536fefe
Show file tree
Hide file tree
Showing 6 changed files with 70 additions and 60 deletions.
10 changes: 8 additions & 2 deletions .github/scripts/validate_binaries.sh
Original file line number Diff line number Diff line change
Expand Up @@ -17,9 +17,9 @@ else
# Please note ffmpeg is required for torchaudio, see https://github.com/pytorch/pytorch/issues/96159
conda create -y -n ${ENV_NAME} python=${MATRIX_PYTHON_VERSION} numpy ffmpeg
conda activate ${ENV_NAME}

# Remove when https://github.com/pytorch/builder/issues/1985 is fixed
if [[ ${MATRIX_GPU_ARCH_TYPE} == 'cuda-aarch64' ]]; then
if [[ ${MATRIX_GPU_ARCH_TYPE} == 'cuda-aarch64' ]]; then
pip3 install numpy --force-reinstall
fi

Expand All @@ -35,6 +35,12 @@ else
INSTALLATION=${INSTALLATION/"--index-url"/"--extra-index-url"}
fi

# use-meta-cdn: use meta cdn for pypi download
if [[ ${USE_META_CDN} == 'true' ]]; then
INSTALLATION=${INSTALLATION/"download.pytorch.org"/"d3kup0pazkvub8.cloudfront.net"}
fi


if [[ ${TORCH_ONLY} == 'true' ]]; then
INSTALLATION=${INSTALLATION/"torchvision torchaudio"/""}
TEST_SUFFIX=" --package torchonly"
Expand Down
23 changes: 12 additions & 11 deletions .github/workflows/validate-aarch64-linux-binaries.yml
Original file line number Diff line number Diff line change
Expand Up @@ -7,11 +7,6 @@ on:
description: "Channel to use (nightly, test, release, all)"
required: true
type: string
ref:
description: 'Reference to checkout, defaults to empty'
default: ""
required: false
type: string
torchonly:
description: 'Validate torchonly'
default: false
Expand Down Expand Up @@ -42,6 +37,11 @@ on:
default: false
required: false
type: boolean
use-meta-cdn:
description: 'Use meta cdn for installing pip binaries'
default: false
required: false
type: boolean
use-extra-index-url:
description: 'Use extra-index url for pip tests'
default: false
Expand All @@ -58,11 +58,6 @@ on:
- nightly
- test
- all
ref:
description: 'Reference to checkout, defaults to empty'
default: ""
required: false
type: string
torchonly:
description: 'Validate torchonly'
default: false
Expand All @@ -88,6 +83,11 @@ on:
default: false
required: false
type: boolean
use-meta-cdn:
description: 'Use meta cdn for installing pip binaries'
default: false
required: false
type: boolean
use-extra-index-url:
description: 'Use extra-index url for pip tests'
default: false
Expand All @@ -114,7 +114,7 @@ jobs:
with:
runner: ${{ matrix.validation_runner }}
repository: "pytorch/builder"
ref: ${{ inputs.ref || github.ref }}
ref: ${{ github.ref }}
job-name: ${{ matrix.build_name }}
docker-image: ${{ matrix.container_image }}
binary-matrix: ${{ toJSON(matrix) }}
Expand All @@ -131,6 +131,7 @@ jobs:
export RELEASE_VERSION=${{ inputs.version }}
export USE_FORCE_REINSTALL=${{ inputs.use-force-reinstall }}
export USE_EXTRA_INDEX_URL=${{ inputs.use-extra-index-url }}
export USE_META_CDN=${{ inputs.use-meta-cdn }}
export USE_VERSION_SET=${{ inputs.use-version-set }}
if [[ ${USE_VERSION_SET} == 'true' ]]; then
export VISION_RELEASE_VERSION=${{ fromJson(inputs.release-matrix).torchvision }}
Expand Down
28 changes: 14 additions & 14 deletions .github/workflows/validate-binaries.yml
Original file line number Diff line number Diff line change
Expand Up @@ -17,11 +17,6 @@ on:
description: "Channel to use (nightly, test, release, all)"
required: true
type: string
ref:
description: 'Reference to checkout, defaults to empty'
default: ""
required: false
type: string
torchonly:
description: 'Validate torchonly'
default: false
Expand All @@ -47,6 +42,11 @@ on:
default: false
required: false
type: boolean
use-meta-cdn:
description: 'Use meta cdn for installing pip binaries'
default: false
required: false
type: boolean
use_split_build:
description: |
[Experimental] Use Split Build
Expand Down Expand Up @@ -81,11 +81,6 @@ on:
- nightly
- test
- all
ref:
description: 'Reference to checkout, defaults to empty'
default: ""
required: false
type: string
torchonly:
description: 'Validate torchonly'
default: false
Expand All @@ -111,6 +106,11 @@ on:
default: false
required: false
type: boolean
use-meta-cdn:
description: 'Use meta cdn for installing pip binaries'
default: false
required: false
type: boolean
use_split_build:
description: |
[Experimental] Use Split Build
Expand All @@ -136,21 +136,20 @@ jobs:
uses: ./.github/workflows/validate-windows-binaries.yml
with:
channel: ${{ inputs.channel }}
ref: ${{ inputs.ref || github.ref }}
torchonly: ${{ inputs.torchonly }}
version: ${{ inputs.version }}
release-matrix: ${{ needs.generate-release-matrix.outputs.matrix }}
use-only-dl-pytorch-org: ${{ inputs.use-only-dl-pytorch-org }}
use-force-reinstall: ${{ inputs.use-force-reinstall }}
use-extra-index-url: ${{ inputs.use-extra-index-url }}
use-meta-cdn: ${{ inputs.use-meta-cdn }}

linux:
if: inputs.os == 'linux' || inputs.os == 'all'
needs: generate-release-matrix
uses: ./.github/workflows/validate-linux-binaries.yml
with:
channel: ${{ inputs.channel }}
ref: ${{ inputs.ref || github.ref }}
torchonly: ${{ inputs.torchonly }}
version: ${{ inputs.version }}
release-matrix: ${{ needs.generate-release-matrix.outputs.matrix }}
Expand All @@ -159,31 +158,32 @@ jobs:
use-force-reinstall: ${{ inputs.use-force-reinstall }}
use_split_build: ${{ inputs.use_split_build }}
use-extra-index-url: ${{ inputs.use-extra-index-url }}
use-meta-cdn: ${{ inputs.use-meta-cdn }}

linux-aarch64:
if: inputs.os == 'linux-aarch64' || inputs.os == 'all'
needs: generate-release-matrix
uses: ./.github/workflows/validate-aarch64-linux-binaries.yml
with:
channel: ${{ inputs.channel }}
ref: ${{ inputs.ref || github.ref }}
torchonly: ${{ inputs.torchonly }}
version: ${{ inputs.version }}
release-matrix: ${{ needs.generate-release-matrix.outputs.matrix }}
use-only-dl-pytorch-org: ${{ inputs.use-only-dl-pytorch-org }}
use-force-reinstall: ${{ inputs.use-force-reinstall }}
use-extra-index-url: ${{ inputs.use-extra-index-url }}
use-meta-cdn: ${{ inputs.use-meta-cdn }}

mac-arm64:
if: inputs.os == 'macos' || inputs.os == 'all'
needs: generate-release-matrix
uses: ./.github/workflows/validate-macos-arm64-binaries.yml
with:
channel: ${{ inputs.channel }}
ref: ${{ inputs.ref || github.ref }}
torchonly: ${{ inputs.torchonly }}
version: ${{ inputs.version }}
release-matrix: ${{ needs.generate-release-matrix.outputs.matrix }}
use-only-dl-pytorch-org: ${{ inputs.use-only-dl-pytorch-org }}
use-force-reinstall: ${{ inputs.use-force-reinstall }}
use-extra-index-url: ${{ inputs.use-extra-index-url }}
use-meta-cdn: ${{ inputs.use-meta-cdn }}
23 changes: 12 additions & 11 deletions .github/workflows/validate-linux-binaries.yml
Original file line number Diff line number Diff line change
Expand Up @@ -7,11 +7,6 @@ on:
description: "Channel to use (nightly, test, release, all)"
required: true
type: string
ref:
description: 'Reference to checkout, defaults to empty'
default: ""
required: false
type: string
torchonly:
description: 'Validate torchonly'
default: false
Expand Down Expand Up @@ -47,6 +42,11 @@ on:
default: false
required: false
type: boolean
use-meta-cdn:
description: 'Use meta cdn for installing pip binaries'
default: false
required: false
type: boolean
use_split_build:
description: |
[Experimental] Use split build
Expand All @@ -69,11 +69,6 @@ on:
- nightly
- test
- all
ref:
description: 'Reference to checkout, defaults to empty'
default: ""
required: false
type: string
torchonly:
description: 'Validate torchonly'
default: false
Expand Down Expand Up @@ -104,6 +99,11 @@ on:
default: false
required: false
type: boolean
use-meta-cdn:
description: 'Use meta cdn for installing pip binaries'
default: false
required: false
type: boolean
use_split_build:
description: |
[Experimental] Use split build
Expand Down Expand Up @@ -137,7 +137,7 @@ jobs:
with:
runner: ${{ matrix.validation_runner }}
repository: "pytorch/builder"
ref: ${{ inputs.ref || github.ref }}
ref: ${{ github.ref }}
job-name: ${{ matrix.build_name }}
docker-image: ${{ matrix.gpu_arch_type == 'xpu' && matrix.container_image || 'pytorch/conda-builder' }}
binary-matrix: ${{ toJSON(matrix) }}
Expand All @@ -149,6 +149,7 @@ jobs:
export INCLUDE_TEST_OPS=${{ inputs.include-test-ops }}
export USE_ONLY_DL_PYTORCH_ORG=${{ inputs.use-only-dl-pytorch-org }}
export USE_EXTRA_INDEX_URL=${{ inputs.use-extra-index-url }}
export USE_META_CDN=${{ inputs.use-meta-cdn }}
export RELEASE_VERSION=${{ inputs.version }}
export USE_VERSION_SET=${{ inputs.use-version-set }}
if [[ ${USE_VERSION_SET} == 'true' ]]; then
Expand Down
23 changes: 12 additions & 11 deletions .github/workflows/validate-macos-arm64-binaries.yml
Original file line number Diff line number Diff line change
Expand Up @@ -7,11 +7,6 @@ on:
description: "Channel to use (nightly, test, release, all)"
required: true
type: string
ref:
description: 'Reference to checkout, defaults to empty'
default: ""
required: false
type: string
torchonly:
description: 'Validate torchonly'
default: false
Expand Down Expand Up @@ -42,6 +37,11 @@ on:
default: false
required: false
type: boolean
use-meta-cdn:
description: 'Use meta cdn for installing pip binaries'
default: false
required: false
type: boolean
use-extra-index-url:
description: 'Use extra-index url for pip tests'
default: false
Expand All @@ -58,11 +58,6 @@ on:
- nightly
- test
- all
ref:
description: 'Reference to checkout, defaults to empty'
default: ""
required: false
type: string
torchonly:
description: 'Validate torchonly'
default: false
Expand All @@ -88,6 +83,11 @@ on:
default: false
required: false
type: boolean
use-meta-cdn:
description: 'Use meta cdn for installing pip binaries'
default: false
required: false
type: boolean
use-extra-index-url:
description: 'Use extra-index url for pip tests'
default: false
Expand All @@ -113,7 +113,7 @@ jobs:
with:
runner: ${{ matrix.validation_runner }}
repository: "pytorch/builder"
ref: ${{ inputs.ref || github.ref }}
ref: ${{ github.ref }}
job-name: ${{ matrix.build_name }}
binary-matrix: ${{ toJSON(matrix) }}
script: |
Expand All @@ -124,6 +124,7 @@ jobs:
export RELEASE_VERSION=${{ inputs.version }}
export USE_FORCE_REINSTALL=${{ inputs.use-force-reinstall }}
export USE_EXTRA_INDEX_URL=${{ inputs.use-extra-index-url }}
export USE_META_CDN=${{ inputs.use-meta-cdn }}
export USE_VERSION_SET=${{ inputs.use-version-set }}
if [[ ${{ matrix.package_type }} == "conda" ]]; then
Expand Down
23 changes: 12 additions & 11 deletions .github/workflows/validate-windows-binaries.yml
Original file line number Diff line number Diff line change
Expand Up @@ -7,11 +7,6 @@ on:
description: "Channel to use (nightly, test, release, all)"
required: true
type: string
ref:
description: 'Reference to checkout, defaults to empty'
default: ""
required: false
type: string
torchonly:
description: 'Validate torchonly'
default: false
Expand Down Expand Up @@ -42,6 +37,11 @@ on:
default: false
required: false
type: boolean
use-meta-cdn:
description: 'Use meta cdn for installing pip binaries'
default: false
required: false
type: boolean
use-extra-index-url:
description: 'Use extra-index url for pip tests'
default: false
Expand All @@ -58,11 +58,6 @@ on:
- nightly
- test
- all
ref:
description: 'Reference to checkout, defaults to empty'
default: ""
required: false
type: string
torchonly:
description: 'Validate torchonly'
default: false
Expand All @@ -88,6 +83,11 @@ on:
default: false
required: false
type: boolean
use-meta-cdn:
description: 'Use meta cdn for installing pip binaries'
default: false
required: false
type: boolean
use-extra-index-url:
description: 'Use extra-index url for pip tests'
default: false
Expand All @@ -113,7 +113,7 @@ jobs:
with:
runner: ${{ matrix.package_type == 'libtorch' && 'windows.4xlarge' || matrix.validation_runner }}
repository: "pytorch/builder"
ref: ${{ inputs.ref || github.ref }}
ref: ${{ github.ref }}
job-name: ${{ matrix.build_name }}
binary-matrix: ${{ toJSON(matrix) }}
timeout: 60
Expand All @@ -125,6 +125,7 @@ jobs:
export RELEASE_VERSION=${{ inputs.version }}
export USE_FORCE_REINSTALL=${{ inputs.use-force-reinstall }}
export USE_EXTRA_INDEX_URL=${{ inputs.use-extra-index-url }}
export USE_META_CDN=${{ inputs.use-meta-cdn }}
export USE_VERSION_SET=${{ inputs.use-version-set }}
if [[ ${USE_VERSION_SET} == 'true' ]]; then
export VISION_RELEASE_VERSION=${{ fromJson(inputs.release-matrix).torchvision }}
Expand Down

0 comments on commit 536fefe

Please sign in to comment.