Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin conda-build to 3.28.4 #1698

Merged
merged 2 commits into from
Feb 6, 2024
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions conda/build_pytorch.sh
Original file line number Diff line number Diff line change
Expand Up @@ -208,7 +208,8 @@ if [[ "$(uname)" == 'Darwin' ]]; then
"$miniconda_sh" -b -p "$tmp_conda" && \
rm "$miniconda_sh"
export PATH="$tmp_conda/bin:$PATH"
retry conda install -yq conda-build
# TODO(huydhn): We can revert the pin after https://github.com/conda/conda-build/issues/5167 is resolved
retry conda install -yq conda-build=3.28.4
elif [[ "$OSTYPE" == "msys" ]]; then
export tmp_conda="${WIN_PACKAGE_WORK_DIR}\\conda"
export miniconda_exe="${WIN_PACKAGE_WORK_DIR}\\miniconda.exe"
Expand All @@ -219,7 +220,8 @@ elif [[ "$OSTYPE" == "msys" ]]; then
pushd $tmp_conda
export PATH="$(pwd):$(pwd)/Library/usr/bin:$(pwd)/Library/bin:$(pwd)/Scripts:$(pwd)/bin:$PATH"
popd
retry conda install -yq conda-build
# TODO(huydhn): We can revert the pin after https://github.com/conda/conda-build/issues/5167 is resolved
Copy link
Contributor

@atalman atalman Feb 6, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since failure is with MacOS only we probably don't need to apply this constraint to windows. Only MacOS should be enough. Also I see that windows test is failing: https://github.com/pytorch/pytorch/actions/runs/7794015875/job/21254659194#step:12:2556

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I hope that conda doesn't put us into a situation where both pinning an older version and using the latest version fail :)

retry conda install -yq conda-build=3.28.4
fi

cd "$SOURCE_DIR"
Expand Down Expand Up @@ -351,8 +353,6 @@ for py_ver in "${DESIRED_PYTHON[@]}"; do
conda install -y conda-package-handling conda==22.9.0
else
conda install -y conda-package-handling conda==23.5.2
# NS: To be removed after conda docker images are updated
conda update -y conda-build
fi

echo "Calling conda-build at $(date)"
Expand Down
Loading