Update nightly wheel build numpy to 2.0 #1747
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Update wheel build numpy to 2.0 * aarch64
atalman
changed the title
albanD
approved these changes
Mar 20, 2024
| if "%DESIRED_PYTHON%" == "3.12" pip install -q --pre numpy==2.0.0b1 protobuf | ||
| if "%DESIRED_PYTHON%" == "3.11" pip install -q --pre numpy==2.0.0b1 protobuf | ||
| if "%DESIRED_PYTHON%" == "3.10" pip install -q --pre numpy==2.0.0b1 protobuf | ||
| if "%DESIRED_PYTHON%" == "3.9" pip install -q --pre numpy==2.0.0b1 protobuf |
There was a problem hiding this comment.
nit: maybe we can make this an else to avoid having the same lines multiple times?
There was a problem hiding this comment.
Unfortunately this is windows limitation, see: https://superuser.com/questions/1641210/multiple-if-else-conditions-in-batch-file
3 tasks
atalman
added a commit
to atalman/builder
that referenced
this pull request
Apr 4, 2024
* Update wheel build numpy to 2.0 (pytorch#1746) * Update wheel build numpy to 2.0 * aarch64 * Update build_wheel.sh * Simplify
This was referenced Apr 4, 2024
atalman
added a commit
that referenced
this pull request
Apr 4, 2024
* [BE] Remove macos x86 build statements, remove python <3.8 (#1745) * [BE] Remove macos x86 build statements, remove python <3.8 * fix * deprecate * Update nightly wheel build numpy to 2.0 (#1747) * Update wheel build numpy to 2.0 (#1746) * Update wheel build numpy to 2.0 * aarch64 * Update build_wheel.sh * Simplify * Install llvm-openmp for M1 PyTorch builds Otherwise the binary will be super slow Also drop `nomkl` as there were never mkl on Apple silicon * Add numpy 2.0.0rc1 support to conda and wheels (#1768) * Add numpy 2.0.0rc1 support to conda and wheels * conda * conda * test * fix * Add numpy 2.0.0rc1 support to conda and wheels (#1769) --------- Co-authored-by: Nikita Shulga <2453524+malfet@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test In: pytorch/pytorch#121979