Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BE] cleanup install_cuda.sh script #1942

Merged
merged 1 commit into from
Jul 29, 2024

Conversation

atalman
Copy link
Contributor

@atalman atalman commented Jul 29, 2024

Follow up after pytorch/pytorch#129022 . Remove unused scripts.
Env var: OVERRIDE_TORCH_CUDA_ARCH_LIST was added by #604 ~4 yrs ago and its not used in our CI/CD

@atalman atalman changed the title Builder install_cuda cleanup [BE] cleanup install_cuda.sh script Jul 29, 2024
@atalman atalman merged commit e7b7315 into pytorch:main Jul 29, 2024
2 checks passed
@atalman atalman deleted the builder_install_cuda_cleanup branch July 29, 2024 22:39
atalman added a commit that referenced this pull request Jul 30, 2024
facebook-github-bot pushed a commit to pytorch/benchmark that referenced this pull request Jul 30, 2024
Summary:
install_cuda.sh has been moved from pytorch/builder to pytorch/pytorch:

pytorch/builder#1942
pytorch/pytorch#129022

We need to make sure that sm_90a is included:
```
xargs -I '{}' bash -c 'echo {} && /usr/local/cuda-12.4/bin/nvprune -gencode arch=compute_80,code=sm_80 -gencode arch=compute_86,code=sm_86 -gencode arch=compute_90,code=sm_90 -gencode arch=compute_90a,code=sm_90a /usr/local/cuda-12.4/lib64/{} -o /usr/local/cuda-12.4/lib64/{}'
```

Pull Request resolved: #2397

Test Plan: https://github.com/pytorch/benchmark/actions/runs/10163701096

Reviewed By: atalman

Differential Revision: D60454551

Pulled By: xuzhao9

fbshipit-source-id: 03322314b190e0fb95e7d7741152de65ab35ecd4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants