Pin setuptools 72.1.0 #1995
Merged
Pin setuptools 72.1.0 #1995
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
malfet
approved these changes
Sep 18, 2024
kit1980
reviewed
Sep 18, 2024
| if "%%v" == "3.11" call conda create -n py!PYTHON_VERSION_STR! -y -q -c=conda-forge numpy=2.0.1 pyyaml boto3 cmake ninja typing_extensions setuptools python=%%v | ||
| if "%%v" == "3.12" call conda create -n py!PYTHON_VERSION_STR! -y -q -c=conda-forge numpy=2.0.1 pyyaml boto3 cmake ninja typing_extensions setuptools python=%%v | ||
| if "%%v" == "3.13" call conda create -n py!PYTHON_VERSION_STR! -y -q -c=conda-forge numpy=2.0.1 pyyaml boto3 cmake ninja typing_extensions setuptools python=%%v | ||
| if "%%v" == "3.8" call conda create -n py!PYTHON_VERSION_STR! -y -q numpy=1.11 pyyaml boto3 cmake ninja typing_extensions setuptools=72.1.0 python=%%v |
kit1980
approved these changes
Sep 18, 2024
atalman
commented
Sep 18, 2024
atalman
added a commit
that referenced
this pull request
Sep 23, 2024
Same underlyning issue as wheel/libtorch build failure fixed by: #1995
pytorchmergebot
pushed a commit
to pytorch/pytorch
that referenced
this pull request
Sep 25, 2024
FIXES: #136541 Setuptools>=74.0.0 has deprecated support for some functions in distutils, and so the builds run into error such as ```AttributeError: module 'distutils' has no attribute '_msvccompiler'```. Also, the pytorch builds have setuptools pin to 72.1.0 according to these PRs: pytorch/builder#1995 and pytorch/builder@89d9a8c. So, until there is a fix to change the function usage in accordance with latest setuptools, the 72.1.0 version works fine. Also observed in CI jobs: https://github.com/pytorch/pytorch/actions/runs/10979326524 Pull Request resolved: #136489 Approved by: https://github.com/malfet Co-authored-by: Nikita Shulga <2453524+malfet@users.noreply.github.com>
kit1980
pushed a commit
that referenced
this pull request
Sep 26, 2024
* pin_setuptools_72.1.0 * Update windows/condaenv.bat
kit1980
pushed a commit
that referenced
this pull request
Sep 26, 2024
Same underlyning issue as wheel/libtorch build failure fixed by: #1995
pytorchbot
pushed a commit
to pytorch/pytorch
that referenced
this pull request
Sep 26, 2024
FIXES: #136541 Setuptools>=74.0.0 has deprecated support for some functions in distutils, and so the builds run into error such as ```AttributeError: module 'distutils' has no attribute '_msvccompiler'```. Also, the pytorch builds have setuptools pin to 72.1.0 according to these PRs: pytorch/builder#1995 and pytorch/builder@89d9a8c. So, until there is a fix to change the function usage in accordance with latest setuptools, the 72.1.0 version works fine. Also observed in CI jobs: https://github.com/pytorch/pytorch/actions/runs/10979326524 Pull Request resolved: #136489 Approved by: https://github.com/malfet Co-authored-by: Nikita Shulga <2453524+malfet@users.noreply.github.com> (cherry picked from commit 8d65d9f)
kit1980
pushed a commit
to pytorch/pytorch
that referenced
this pull request
Sep 26, 2024
Constraint setuptools to 72.1.0 or older in requirements.txt (#136489) FIXES: #136541 Setuptools>=74.0.0 has deprecated support for some functions in distutils, and so the builds run into error such as ```AttributeError: module 'distutils' has no attribute '_msvccompiler'```. Also, the pytorch builds have setuptools pin to 72.1.0 according to these PRs: pytorch/builder#1995 and pytorch/builder@89d9a8c. So, until there is a fix to change the function usage in accordance with latest setuptools, the 72.1.0 version works fine. Also observed in CI jobs: https://github.com/pytorch/pytorch/actions/runs/10979326524 Pull Request resolved: #136489 Approved by: https://github.com/malfet Co-authored-by: Nikita Shulga <2453524+malfet@users.noreply.github.com> (cherry picked from commit 8d65d9f) Co-authored-by: ratnampa <ratnam.parikh@intel.com>
pytorchmergebot
pushed a commit
to sanchitintel/pytorch
that referenced
this pull request
Sep 26, 2024
…#136489) FIXES: pytorch#136541 Setuptools>=74.0.0 has deprecated support for some functions in distutils, and so the builds run into error such as ```AttributeError: module 'distutils' has no attribute '_msvccompiler'```. Also, the pytorch builds have setuptools pin to 72.1.0 according to these PRs: pytorch/builder#1995 and pytorch/builder@89d9a8c. So, until there is a fix to change the function usage in accordance with latest setuptools, the 72.1.0 version works fine. Also observed in CI jobs: https://github.com/pytorch/pytorch/actions/runs/10979326524 Pull Request resolved: pytorch#136489 Approved by: https://github.com/malfet Co-authored-by: Nikita Shulga <2453524+malfet@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test: https://github.com/pytorch/pytorch/actions/runs/10931527757/job/30346683455?pr=136293