Add randomtemp to build scripts #448
Conversation
| set RANDOMTEMP_EXECUTABLE=%SRC_DIR%\tmp_bin\nvcc.exe | ||
| set CUDA_NVCC_EXECUTABLE=%SRC_DIR%\tmp_bin\randomtemp.exe |
There was a problem hiding this comment.
Shouldn't this be other way around?
There was a problem hiding this comment.
Could you please give an example?
There was a problem hiding this comment.
Currently, we can only workground this issue by retrying it several times.
There was a problem hiding this comment.
Why RANDOMTEMP_EXECUTABLE is points to nvcc and CUDA_NVCC_EXECUTABLE poitns to randomtemp.exe?
There was a problem hiding this comment.
Because randomtemp.exe acts like a shim exectuable, it just passes the argument to the actual program, which is specified by the variable RANDOMTEMP_EXECUTABLE.
There was a problem hiding this comment.
Yea I agree with @malfet this does seem a bit confusing when you look at it.
Maybe it'd be better to add a comment here explaining why they point where they point to.
There was a problem hiding this comment.
I think I understand how it works, but naming of variables is a bit confusing, but indeed it matches one on master
|
The cuda builds in nightly jobs seem to be more flaky with the new circleci image which has VS 16.6 installed. So I hope that we could land this asap. |
3 participants
Fixes pytorch/pytorch#25393.
Applies https://github.com/pytorch/pytorch/pull/35375/files to pytorch/builder.
@malfet @seemethere @soumith