Skip to content

Fix failing GPU errors for influential examples #1081

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 5 commits into from

Conversation

NarineK
Copy link
Contributor

@NarineK NarineK commented Dec 5, 2022

Due to floating point arithmetic inaccuracies and limitations switching to double for test cases and passing dtype to projection matrix so that the the arithmetic error is within accepted range.

Copy link
Contributor

@vivekmig vivekmig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks for fixing this!

@NarineK NarineK force-pushed the fix_failing_tracin_gpu_errors branch from a7378ca to 7cc1066 Compare December 11, 2022 21:32
@NarineK NarineK changed the title Fix failing GPU errors Fix failing GPU errors for influential examples Dec 12, 2022
@facebook-github-bot
Copy link
Contributor

@NarineK has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

@NarineK merged this pull request in 8bc12c8.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants