Clean install_via_conda #1097
Closed
Clean install_via_conda #1097
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aobo-y
changed the title
|
@aobo-y has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
@aobo-y has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Circle CI job
test_condais failing because of some missing dependencies, likeThe cause is that when we install
nodejsthrough conda, it will upgrade some packages, likeThe newer version is not be compatible with some python packages.
Downgrade those incompatible packages will fix the issue. But I made this PR to just drop the installations of
nodejsandyarn(and some other unused packages likemypyflake8). Also stop buildingcaptum-insightI feel
nodejs&yarnare used for building the website and Insight's frontend. However, this script is only used in for CircleCI's conda testing, which does not execute anything related to Insight frontend or build website, so it safe to remove them.(I am not sure why we include them in the 1st place. Let me know if I missed some use cases of this script)