Simplify the get_random_model_and_data() method #1251
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request was exported from Phabricator. Differential Revision: D55153967 |
cicichen01
added a commit
to cicichen01/captum
that referenced
this pull request
Mar 20, 2024
Summary: As titled. The get_random_model_and_data() method is used to construct testing data for influence and it is reported as too complex by flake8 (https://www.flake8rules.com/rules/C901.html). This series of diff will split the method and abstract the common parts. This diff isolate the model part for different gpu usage settings. It also eliminate the mix usage of bool and str. Differential Revision: D55153967
cicichen01
force-pushed
the
export-D55153967
branch
from
732c1f9 to
00ae18f
Compare
|
This pull request was exported from Phabricator. Differential Revision: D55153967 |
cicichen01
added a commit
to cicichen01/captum
that referenced
this pull request
Mar 20, 2024
Summary: As titled. The sample data type is fixed after construction and should be handled separately based on its type. Differential Revision: D55153967
cicichen01
force-pushed
the
export-D55153967
branch
from
00ae18f to
4d61776
Compare
|
This pull request was exported from Phabricator. Differential Revision: D55153967 |
Summary: As titled. The sample data type is fixed after construction and should be handled separately based on its type. Differential Revision: D55153967
cicichen01
force-pushed
the
export-D55153967
branch
from
4d61776 to
156ca7a
Compare
|
This pull request was exported from Phabricator. Differential Revision: D55153967 |
cicichen01
added a commit
to cicichen01/captum
that referenced
this pull request
Mar 21, 2024
Summary: As titled. The sample data type is fixed after construction and should be handled separately based on its type. Differential Revision: D55153967
cicichen01
changed the title
cicichen01
added a commit
to cicichen01/captum
that referenced
this pull request
Mar 21, 2024
Summary: As titled. The sample data type is fixed after construction and should be handled separately based on its type. Differential Revision: D55153967
cicichen01
added a commit
to cicichen01/captum
that referenced
this pull request
Mar 21, 2024
Summary: As titled. The sample data type is fixed after construction and should be handled separately based on its type. Differential Revision: D55153967
|
This pull request has been merged in 80c7ce5. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
As titled. The sample data type is fixed after construction and should be handled separately based on its type.
Differential Revision: D55153967