Adding a new Module for unsupported layer. Adding test for unsupported layers. Simple logging for unsupported layers #1505
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request was exported from Phabricator. Differential Revision: D69792994 |
styusuf
force-pushed
the
export-D69792994
branch
from
d2b3684 to
bd7e67a
Compare
styusuf
added a commit
to styusuf/captum
that referenced
this pull request
Feb 21, 2025
…d layers. Simple logging for unsupported layers (pytorch#1505) Summary: We are adding test for unsupported gradient layers. Open to ideas if there is a better way to structure the test. A bit uncomfortable with removing pyre type validations as we allow anything to be passed into the GradientUnsupportedLayerOutput class. Differential Revision: D69792994
|
This pull request was exported from Phabricator. Differential Revision: D69792994 |
1 similar comment
|
This pull request was exported from Phabricator. Differential Revision: D69792994 |
styusuf
added a commit
to styusuf/captum
that referenced
this pull request
Feb 21, 2025
…d layers. Simple logging for unsupported layers (pytorch#1505) Summary: We are adding test for unsupported gradient layers. Open to ideas if there is a better way to structure the test. A bit uncomfortable with removing pyre type validations as we allow anything to be passed into the GradientUnsupportedLayerOutput class. Differential Revision: D69792994
styusuf
force-pushed
the
export-D69792994
branch
from
bd7e67a to
14d7d12
Compare
|
This pull request was exported from Phabricator. Differential Revision: D69792994 |
styusuf
added a commit
to styusuf/captum
that referenced
this pull request
Feb 21, 2025
…d layers. Simple logging for unsupported layers (pytorch#1505) Summary: We are adding test for unsupported gradient layers. Open to ideas if there is a better way to structure the test. A bit uncomfortable with removing pyre type validations as we allow anything to be passed into the GradientUnsupportedLayerOutput class. Differential Revision: D69792994
styusuf
force-pushed
the
export-D69792994
branch
from
14d7d12 to
f5b2c17
Compare
|
This pull request was exported from Phabricator. Differential Revision: D69792994 |
styusuf
force-pushed
the
export-D69792994
branch
from
f5b2c17 to
35912f9
Compare
styusuf
added a commit
to styusuf/captum
that referenced
this pull request
Mar 2, 2025
…d layers. Simple logging for unsupported layers (pytorch#1505) Summary: We are adding test for unsupported gradient layers. Open to ideas if there is a better way to structure the test. A bit uncomfortable with removing pyre type validations as we allow anything to be passed into the GradientUnsupportedLayerOutput class. Differential Revision: D69792994
|
This pull request was exported from Phabricator. Differential Revision: D69792994 |
styusuf
added a commit
to styusuf/captum
that referenced
this pull request
Mar 3, 2025
…d layers. Simple logging for unsupported layers (pytorch#1505) Summary: We are adding test for unsupported gradient layers. Open to ideas if there is a better way to structure the test. A bit uncomfortable with removing pyre type validations as we allow anything to be passed into the GradientUnsupportedLayerOutput class. Differential Revision: D69792994
styusuf
force-pushed
the
export-D69792994
branch
from
35912f9 to
dc400ac
Compare
|
This pull request was exported from Phabricator. Differential Revision: D69792994 |
styusuf
added a commit
to styusuf/captum
that referenced
this pull request
Mar 3, 2025
…d layers. Simple logging for unsupported layers (pytorch#1505) Summary: We are adding test for unsupported gradient layers. Open to ideas if there is a better way to structure the test. A bit uncomfortable with removing pyre type validations as we allow anything to be passed into the GradientUnsupportedLayerOutput class. Differential Revision: D69792994
styusuf
force-pushed
the
export-D69792994
branch
from
dc400ac to
538d753
Compare
|
This pull request was exported from Phabricator. Differential Revision: D69792994 |
styusuf
added a commit
to styusuf/captum
that referenced
this pull request
Mar 3, 2025
…d layers. Simple logging for unsupported layers (pytorch#1505) Summary: We are adding test for unsupported gradient layers. Open to ideas if there is a better way to structure the test. A bit uncomfortable with removing pyre type validations as we allow anything to be passed into the GradientUnsupportedLayerOutput class. Differential Revision: D69792994
styusuf
force-pushed
the
export-D69792994
branch
from
538d753 to
976bf30
Compare
|
This pull request was exported from Phabricator. Differential Revision: D69792994 |
styusuf
added a commit
to styusuf/captum
that referenced
this pull request
Mar 4, 2025
…d layers. Simple logging for unsupported layers (pytorch#1505) Summary: We are adding test for unsupported gradient layers. Open to ideas if there is a better way to structure the test. A bit uncomfortable with removing pyre type validations as we allow anything to be passed into the GradientUnsupportedLayerOutput class. Differential Revision: D69792994
styusuf
force-pushed
the
export-D69792994
branch
from
976bf30 to
11ccffa
Compare
styusuf
added a commit
to styusuf/captum
that referenced
this pull request
Mar 4, 2025
…d layers. Simple logging for unsupported layers (pytorch#1505) Summary: We are adding test for unsupported gradient layers. Open to ideas if there is a better way to structure the test. A bit uncomfortable with removing pyre type validations as we allow anything to be passed into the GradientUnsupportedLayerOutput class. Differential Revision: D69792994
styusuf
force-pushed
the
export-D69792994
branch
from
11ccffa to
38ecc4c
Compare
|
This pull request was exported from Phabricator. Differential Revision: D69792994 |
styusuf
force-pushed
the
export-D69792994
branch
from
38ecc4c to
2fa1018
Compare
styusuf
added a commit
to styusuf/captum
that referenced
this pull request
Mar 4, 2025
…d layers. Simple logging for unsupported layers (pytorch#1505) Summary: Pull Request resolved: pytorch#1505 We are adding test for unsupported gradient layers. Open to ideas if there is a better way to structure the test. A bit uncomfortable with removing pyre type validations as we allow anything to be passed into the GradientUnsupportedLayerOutput class. Differential Revision: D69792994
|
This pull request was exported from Phabricator. Differential Revision: D69792994 |
styusuf
added a commit
to styusuf/captum
that referenced
this pull request
Mar 4, 2025
…d layers. Simple logging for unsupported layers (pytorch#1505) Summary: Pull Request resolved: pytorch#1505 We are adding test for unsupported gradient layers. Open to ideas if there is a better way to structure the test. A bit uncomfortable with removing pyre type validations as we allow anything to be passed into the GradientUnsupportedLayerOutput class. Differential Revision: D69792994
styusuf
force-pushed
the
export-D69792994
branch
from
2fa1018 to
f56045a
Compare
styusuf
added a commit
to styusuf/captum
that referenced
this pull request
Mar 5, 2025
…d layers. Simple logging for unsupported layers (pytorch#1505) Summary: We are adding test for unsupported gradient layers. Open to ideas if there is a better way to structure the test. A bit uncomfortable with removing pyre type validations as we allow anything to be passed into the GradientUnsupportedLayerOutput class. Differential Revision: D69792994
styusuf
added a commit
to styusuf/captum
that referenced
this pull request
Mar 5, 2025
…d layers. Simple logging for unsupported layers (pytorch#1505) Summary: We are adding test for unsupported gradient layers. Open to ideas if there is a better way to structure the test. A bit uncomfortable with removing pyre type validations as we allow anything to be passed into the GradientUnsupportedLayerOutput class. Reviewed By: craymichael Differential Revision: D69792994
styusuf
force-pushed
the
export-D69792994
branch
from
f56045a to
3fed752
Compare
…d layers. Simple logging for unsupported layers (pytorch#1505) Summary: Pull Request resolved: pytorch#1505 We are adding test for unsupported gradient layers. Open to ideas if there is a better way to structure the test. A bit uncomfortable with removing pyre type validations as we allow anything to be passed into the GradientUnsupportedLayerOutput class. Reviewed By: craymichael Differential Revision: D69792994
|
This pull request was exported from Phabricator. Differential Revision: D69792994 |
styusuf
force-pushed
the
export-D69792994
branch
from
3fed752 to
66b4bd6
Compare
|
This pull request has been merged in c9688bb. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: We are adding test for unsupported gradient layers. Open to ideas if there is a better way to structure the test.
Differential Revision: D69792994