-
Notifications
You must be signed in to change notification settings - Fork 512
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ability to compare multiple models in Captum Insights #551
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Reubend has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Reubend has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Reubend has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Reubend has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Reubend has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Reubend has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great, thanks!
Summary: This PR adds the ability to compare multiple models in Captum Insights.  In order to test this, I went through two scenarios. First, I made sure there are no regressions to single model workflows like this: 1. Start the Insights example with `python3 -m captum.insights.example` 2. Ensure that the original functionality is still working and there are no changes, other than the visual changes for column headers Then, I tested comparing multiple models by duplicating the existing example one: 1. Go to `example.py` 2. Duplicate the example model, by changing `models=[model]` to `models=[model, model, model]` 3. Check to make sure that it renders properly, and that selecting different target classes works to properly update the data for each visualization Pull Request resolved: #551 Reviewed By: edward-io Differential Revision: D25379744 Pulled By: Reubend fbshipit-source-id: 4999c1ef0f18b8f735cd47a890cef413a7c6548e
This PR adds the ability to compare multiple models in Captum Insights.
In order to test this, I went through two scenarios. First, I made sure there are no regressions to single model workflows like this:
python3 -m captum.insights.example
Then, I tested comparing multiple models by duplicating the existing example one:
example.py
models=[model]
tomodels=[model, model, model]