Optim-wip: Fix & improve cropping transforms #921
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ProGamerGov
force-pushed
the
optim-wip-crop-improvements
branch
from
c20357d to
cd672a0
Compare
ProGamerGov
force-pushed
the
optim-wip-crop-improvements
branch
2 times, most recently
from
a061b57 to
b2e0015
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains the following fixes & improvements from the JIT transforms PR here: #821, to make it easier to review.
Fix bug with
RandomCropJIT support for
RandomCrop,CenterCrop, andcenter_crop. This required changing some of the type hints.CenterCrop/center_cropnow adds padding if the crop size is larger than the input dimensions. This is extremely useful for models that require a specific input size, like CLIP models.Added more comprehensive testing to for
RandomCrop,CenterCrop, andcenter_crop. Test coverage reported by pytest should now be 100% minus the version specific tests.