Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Failing DataLoader2Integration Test #841

Closed
2 tasks done
ejguan opened this issue Oct 19, 2022 · 2 comments
Closed
2 tasks done

Failing DataLoader2Integration Test #841

ejguan opened this issue Oct 19, 2022 · 2 comments

Comments

@ejguan
Copy link
Contributor

ejguan commented Oct 19, 2022 •
edited
Loading

🐛 Describe the bug

After my PR is landed, the nightly releases become broken. See https://github.com/pytorch/data/actions/runs/3281029405

  • Fix the test
  • Investigate why the test is failing but succeeded on PR. And, the integration test is unrelated to my PR

Versions

main branch
@ejguan
Copy link
Contributor Author

ejguan commented Oct 19, 2022

Found the culprit https://github.com/pytorch/pytorch/pull/87017/files
We should check isinstance(datapipe, (MapDataPipe, IterDataPipe)). Sending a fix now

@ejguan ejguan mentioned this issue Oct 19, 2022
Closed
pytorchmergebot pushed a commit to pytorch/pytorch that referenced this issue Oct 20, 2022
@ejguan @pytorchmergebot
[DataPipe] Fix type checking to accept both Iter and Map DataPipe (#8…
b90db4a 
…7285)

Fixes pytorch/data#841

Pull Request resolved: #87285
Approved by: https://github.com/NivekT
@ejguan
Copy link
Contributor Author

ejguan commented Oct 20, 2022

Closing this issue as the fix has been landed.

@ejguan ejguan closed this as completed Oct 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[DataPipe] Fix type checking to accept both Iter and Map DataPipe ejguan/pytorch
1 participant
@ejguan