Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DataLoader2] Removing delegation for 'pause', 'limit', and 'resume' #1011

Closed
wants to merge 5 commits into from

Conversation

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Feb 13, 2023
@NivekT NivekT marked this pull request as draft February 13, 2023 21:47
@NivekT
Copy link
Contributor Author

NivekT commented Feb 13, 2023

@NivekT has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@NivekT
Copy link
Contributor Author

NivekT commented Feb 15, 2023

@NivekT has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

@NivekT merged this pull request in d7835c0.

NivekT added a commit that referenced this pull request Feb 28, 2023
Summary: Pull Request resolved: #1011

Test Plan: Imported from OSS

Reviewed By: mingyuzh, ejguan

Differential Revision: D43251818

Pulled By: NivekT

fbshipit-source-id: 5c34e1a71438308366b473c5d4d075a8158088f1
ejguan pushed a commit that referenced this pull request Feb 28, 2023
Summary: Pull Request resolved: #1011

Test Plan: Imported from OSS

Reviewed By: mingyuzh, ejguan

Differential Revision: D43251818

Pulled By: NivekT

fbshipit-source-id: 5c34e1a71438308366b473c5d4d075a8158088f1
@facebook-github-bot
Copy link
Contributor

This pull request has been reverted by e74ed43.

@NivekT
Copy link
Contributor Author

NivekT commented Mar 2, 2023

This will be re-landed when internal issues are addressed

@facebook-github-bot facebook-github-bot deleted the gh/NivekT/107/head branch March 3, 2023 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged Reverted
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants