Attach traceback to Exception & Test disatpching process (#1036) #1038
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: Partially fixes pytorch#969 ### Changes - Add `ExceptionWrapper` to attach traceback to the Exception - Reason: traceback is unserializable. So, it has to be passed by string - In order to provide informative Error message, pass name for each process like `dispatching process` and `worker process <id>`. - Add tests to validate Error propagation from the dispatching process - parametrize the tests - Fix a bug for `round_robin_demux` to return a list of DataPipe rather than a single DataPipe when `num_of_instances` is 1. Pull Request resolved: pytorch#1036 Reviewed By: NivekT Differential Revision: D43472709 Pulled By: ejguan fbshipit-source-id: e5c9e581ca881f523fb568b6f46bf16ecfc243d2
facebook-github-bot
added
the
CLA Signed
NivekT
approved these changes
Feb 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-pick: #1036
Summary:
Partially fixes #969
Changes
ExceptionWrapperto attach traceback to the Exceptiondispatching processandworker process <id>.round_robin_demuxto return a list of DataPipe rather than a single DataPipe whennum_of_instancesis 1.Pull Request resolved: #1036
Reviewed By: NivekT
Differential Revision: D43472709
Pulled By: ejguan
fbshipit-source-id: e5c9e581ca881f523fb568b6f46bf16ecfc243d2