-
Notifications
You must be signed in to change notification settings - Fork 152
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DataPipe] Skip FullSync operation when world_size == 1 #1065
Conversation
[ghstack-poisoned]
ghstack-source-id: 7547f29c1bf8bdf1943285c15d89187b3cda7dad Pull Request resolved: #1065
@NivekT has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approve with one comment
Differential Revision: [D43751382](https://our.internmc.facebook.com/intern/diff/D43751382) [ghstack-poisoned]
ghstack-source-id: 18f4cdb035fea1e74592d953eb8cecc7141e3f2c Pull Request resolved: #1065
@NivekT has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Differential Revision: [D43751382](https://our.internmc.facebook.com/intern/diff/D43751382) [ghstack-poisoned]
@NivekT has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Differential Revision: [D43751382](https://our.internmc.facebook.com/intern/diff/D43751382) [ghstack-poisoned]
ghstack-source-id: d5bd3db7115c387351e65ee31295542783386f0b Pull Request resolved: #1065
@NivekT has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Differential Revision: [D43751382](https://our.internmc.facebook.com/intern/diff/D43751382) [ghstack-poisoned]
ghstack-source-id: 9f27159e84c823bb706c1054c49c2a8c6556f0e1 Pull Request resolved: #1065
@NivekT has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we add a test?
Differential Revision: [D43751382](https://our.internmc.facebook.com/intern/diff/D43751382) [ghstack-poisoned]
ghstack-source-id: f22a775ea7c4bf8743f281f7bcc1637823fad426 Pull Request resolved: #1065
@NivekT has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Differential Revision: [D43751382](https://our.internmc.facebook.com/intern/diff/D43751382) [ghstack-poisoned]
ghstack-source-id: de637603e941e347f24e615e475851e85b802bd7 Pull Request resolved: #1065
@NivekT has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Summary: Pull Request resolved: #1065 Test Plan: Imported from OSS Reviewed By: ejguan Differential Revision: D43751382 Pulled By: NivekT fbshipit-source-id: cd85e6dc360494289b82facb0cee34502a178c27
Summary: Pull Request resolved: #1065 Test Plan: Imported from OSS Reviewed By: ejguan Differential Revision: D43751382 Pulled By: NivekT fbshipit-source-id: cd85e6dc360494289b82facb0cee34502a178c27
Summary: Pull Request resolved: #1065 Test Plan: Imported from OSS Reviewed By: ejguan Differential Revision: D43751382 Pulled By: NivekT fbshipit-source-id: cd85e6dc360494289b82facb0cee34502a178c27
Stack from ghstack:
Differential Revision: D43751382