Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add long description to setup.py #1094

Conversation

MoritzThomasHuebner
Copy link
Contributor

@MoritzThomasHuebner MoritzThomasHuebner commented Mar 16, 2023

Fixes #1088

Changes

  • Added the README.md as a long description in the setup.py
  • Added long_description_content_type field

Co-Authored by:
Martin Achtner martin.achtner@tngtech.com
Jad Saliba jad.saliba@tngtech.com

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Mar 16, 2023
@MoritzThomasHuebner MoritzThomasHuebner marked this pull request as ready for review March 16, 2023 23:58
Copy link
Contributor

@ejguan ejguan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you. Could you pls run python setup.py bdist_wheel on your local env to see the result?

@facebook-github-bot
Copy link
Contributor

@ejguan has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

@ejguan merged this pull request in 4e8573f.

@ejguan
Copy link
Contributor

ejguan commented Mar 20, 2023

Thank you. Could you pls run python setup.py bdist_wheel on your local env to see the result?

Validated on my local environment after the merge

@ejguan ejguan added this to the 0.6.1 milestone Mar 20, 2023
NivekT pushed a commit that referenced this pull request Apr 19, 2023
Summary:
Fixes #1088

### Changes

- Added the README.md as a long description in the `setup.py`
- Added `long_description_content_type` field

Co-Authored by:
Martin Achtner <martin.achtner@tngtech.com>
Jad Saliba <jad.saliba@tngtech.com>

Pull Request resolved: #1094

Reviewed By: NivekT

Differential Revision: D44166989

Pulled By: ejguan

fbshipit-source-id: 24fafc170a825372356aba8c3f086a360902b6c9
ejguan pushed a commit that referenced this pull request Apr 20, 2023
Summary:
Fixes #1088

### Changes

- Added the README.md as a long description in the `setup.py`
- Added `long_description_content_type` field

Co-Authored by:
Martin Achtner <martin.achtner@tngtech.com>
Jad Saliba <jad.saliba@tngtech.com>

Pull Request resolved: #1094

Reviewed By: NivekT

Differential Revision: D44166989

Pulled By: ejguan

fbshipit-source-id: 24fafc170a825372356aba8c3f086a360902b6c9
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update PyPI information
4 participants